linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: v9fs-developer@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, ericvh@gmail.com
Subject: Re: [PATCH 3/3] [net/9p] VirtIO can transfer VIRTQUEUE_NUM of pages.
Date: Fri, 01 Jul 2011 09:27:03 -0700	[thread overview]
Message-ID: <4E0DF557.4070707@linux.vnet.ibm.com> (raw)
In-Reply-To: <8762nmnt0p.fsf@linux.vnet.ibm.com>

On 07/01/2011 04:24 AM, Aneesh Kumar K.V wrote:
> On Thu, 30 Jun 2011 16:18:41 -0700, "Venkateswararao Jujjuri (JV)"<jvrao@linux.vnet.ibm.com>  wrote:
>> Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
>> ---
>>   net/9p/trans_virtio.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
>> index 0ec5423..175b513 100644
>> --- a/net/9p/trans_virtio.c
>> +++ b/net/9p/trans_virtio.c
>> @@ -592,7 +592,7 @@ static struct p9_trans_module p9_virtio_trans = {
>>   	.close = p9_virtio_close,
>>   	.request = p9_virtio_request,
>>   	.cancel = p9_virtio_cancel,
>> -	.maxsize = PAGE_SIZE*16,
>> +	.maxsize = PAGE_SIZE*VIRTQUEUE_NUM,
>>   	.pref = P9_TRANS_PREF_PAYLOAD_SEP,
>>   	.def = 0,
>>   	.owner = THIS_MODULE,
> Reviewed-by: Aneesh Kumar K.V<aneesh.kumar@linux.vnet.ibm.com>
>
> I guess we also need to make sure Qemu server also set the msize to this
> value so that we can operate with large msize ?
QEMU server acks whatever client requests/sends through TVERSION.
Apart from this we need a broader policy on the whole msize on QEMU
to validate the client's proposal before blindly accepting it.

- JV
> -aneesh


  reply	other threads:[~2011-07-01 16:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 23:18 [PATCH 1/3] [net/9p] Fix the size of receive buffer packing onto VirtIO ring Venkateswararao Jujjuri (JV)
2011-06-30 23:18 ` [PATCH 2/3] [net/9p] Fix the msize calculation Venkateswararao Jujjuri (JV)
2011-07-01 11:14   ` Aneesh Kumar K.V
2011-06-30 23:18 ` [PATCH 3/3] [net/9p] VirtIO can transfer VIRTQUEUE_NUM of pages Venkateswararao Jujjuri (JV)
2011-07-01 11:24   ` Aneesh Kumar K.V
2011-07-01 16:27     ` Venkateswararao Jujjuri [this message]
2011-07-01 11:21 ` [PATCH 1/3] [net/9p] Fix the size of receive buffer packing onto VirtIO ring Aneesh Kumar K.V
2011-07-01 16:29   ` Venkateswararao Jujjuri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0DF557.4070707@linux.vnet.ibm.com \
    --to=jvrao@linux.vnet.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=ericvh@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).