From mboxrd@z Thu Jan 1 00:00:00 1970 From: Venkateswararao Jujjuri Subject: Re: [PATCH 3/3] [net/9p] VirtIO can transfer VIRTQUEUE_NUM of pages. Date: Fri, 01 Jul 2011 09:27:03 -0700 Message-ID: <4E0DF557.4070707@linux.vnet.ibm.com> References: <1309475921-12171-1-git-send-email-jvrao@linux.vnet.ibm.com> <1309475921-12171-3-git-send-email-jvrao@linux.vnet.ibm.com> <8762nmnt0p.fsf@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, ericvh@gmail.com To: "Aneesh Kumar K.V" Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:54584 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757037Ab1GAQ1J (ORCPT ); Fri, 1 Jul 2011 12:27:09 -0400 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e32.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p61GFDJA013330 for ; Fri, 1 Jul 2011 10:15:13 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p61GR6kJ206216 for ; Fri, 1 Jul 2011 10:27:06 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p61GR5UO010417 for ; Fri, 1 Jul 2011 10:27:05 -0600 In-Reply-To: <8762nmnt0p.fsf@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 07/01/2011 04:24 AM, Aneesh Kumar K.V wrote: > On Thu, 30 Jun 2011 16:18:41 -0700, "Venkateswararao Jujjuri (JV)" wrote: >> Signed-off-by: Venkateswararao Jujjuri " >> --- >> net/9p/trans_virtio.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c >> index 0ec5423..175b513 100644 >> --- a/net/9p/trans_virtio.c >> +++ b/net/9p/trans_virtio.c >> @@ -592,7 +592,7 @@ static struct p9_trans_module p9_virtio_trans = { >> .close = p9_virtio_close, >> .request = p9_virtio_request, >> .cancel = p9_virtio_cancel, >> - .maxsize = PAGE_SIZE*16, >> + .maxsize = PAGE_SIZE*VIRTQUEUE_NUM, >> .pref = P9_TRANS_PREF_PAYLOAD_SEP, >> .def = 0, >> .owner = THIS_MODULE, > Reviewed-by: Aneesh Kumar K.V > > I guess we also need to make sure Qemu server also set the msize to this > value so that we can operate with large msize ? QEMU server acks whatever client requests/sends through TVERSION. Apart from this we need a broader policy on the whole msize on QEMU to validate the client's proposal before blindly accepting it. - JV > -aneesh