From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Date: Sat, 23 Jul 2011 16:26:48 -0400 Message-ID: <4E2B2E88.8080006@redhat.com> References: <1309370716-12235-1-git-send-email-josef@redhat.com> <20110723180942.GA1616@x4.trippels.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, Dave Chinner , xfs@oss.sgi.com To: Markus Trippelsdorf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38560 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033Ab1GWU1S (ORCPT ); Sat, 23 Jul 2011 16:27:18 -0400 In-Reply-To: <20110723180942.GA1616@x4.trippels.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 07/23/2011 02:09 PM, Markus Trippelsdorf wrote: > On 2011.06.29 at 14:05 -0400, Josef Bacik wrote: >> Btrfs needs to be able to control how filemap_write_and_wait_range() is called >> in fsync to make it less of a painful operation, so push down taking i_mutex and >> the calling of filemap_write_and_wait() down into the ->fsync() handlers. Some >> file systems can drop taking the i_mutex altogether it seems, like ext3 and >> ocfs2. For correctness sake I just pushed everything down in all cases to make >> sure that we keep the current behavior the same for everybody, and then each >> individual fs maintainer can make up their mind about what to do from there. > > At least the xfs part of this patch is broken. > Running the latest git-kernel bogofilter doesn't work anymore on my xfs > partition. When I run "bogoutil -d wordlist.db" to dump the contents of > the database, it produces no output at all. > Already fixed and sent a patch out earlier this week. Thanks, Josef