From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Subject: Re: [PATCH] xfstests: fsx: fix fallocate logging Date: Tue, 09 Aug 2011 08:03:38 -0400 Message-ID: <4E41221A.1030608@redhat.com> References: <1312818914-9950-1-git-send-email-josef@redhat.com> <20110809100658.GQ3162@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org To: Dave Chinner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38268 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753232Ab1HIMDx (ORCPT ); Tue, 9 Aug 2011 08:03:53 -0400 In-Reply-To: <20110809100658.GQ3162@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/09/2011 06:06 AM, Dave Chinner wrote: > On Mon, Aug 08, 2011 at 11:55:14AM -0400, Josef Bacik wrote: >> I've been getting segfaults on fsx tests with btrfs because we're using the >> wrong values for the logging with fallocate. We were using the numbers 1,2 and >> 3 to indicate the type of preallocate we were doing, however we use these to >> point to an array, so obviously array[3] for a 3 element array is wrong, so fix >> these to do 0,1, and 2. Also spit out of we're using KEEP_SIZE in the log to >> make it easier to figure out what's going on. Thanks, >> >> Signed-off-by: Josef Bacik > > Already fixed. > > http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=77c06202484237e26774efbd1774c251b6bef0a9 > Damnit, this is what I get for not git pulling first. Thanks, Josef