From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: marcelo@conectiva.com.br, alan@lxorguk.ukuu.org.uk,
Alexander Viro <viro@math.psu.edu>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2.4.19pre8][RFC] remove-NFS-close-to-open from V
Date: Thu, 17 Oct 2002 23:22:35 +0200 [thread overview]
Message-ID: <4E52C4F573C@vcnet.vc.cvut.cz> (raw)
On 17 Oct 02 at 16:38, Jan Harkes wrote:
>
> Originally, returning a error from d_revalidate in cached_lookup would
> force a subsequent real_lookup. After the patch, returning an error from
> d_revalidate propagates (in some cases) ESTALE back up to userspace.
For example if you do 'ls -l' in root directory of mounted ncpfs
filesystem because of ncpfs did not expect that somebody can
call it with entry name "/" (which contains illegal character for
filename, '/'), and so it refused to believe that such entry is valid...
Best regards,
Petr Vandrovec
vandrove@vc.cvut.cz
> --- 1.19/fs/namei.c Thu Feb 28 05:57:29 2002
> +++ 1.20/fs/namei.c Tue Mar 12 07:35:02 2002
> @@ -627,6 +627,19 @@
> nd->last_type = LAST_DOT;
> else if (this.len == 2 && this.name[1] == '.')
> nd->last_type = LAST_DOTDOT;
> +return_reval:
> + /*
> + * We bypassed the ordinary revalidation routines.
> + * Check the cached dentry for staleness.
> + */
> + dentry = nd->dentry;
> + if (dentry && dentry->d_op && dentry->d_op->d_revalidate) {
> + err = -ESTALE;
> + if (!dentry->d_op->d_revalidate(dentry, 0)) {
> + d_invalidate(dentry);
> + break;
> + }
> + }
> return_base:
> return 0;
> out_dput:
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
reply other threads:[~2002-10-17 21:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E52C4F573C@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).