From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/7] VFS: Add generic_file_llseek_size
Date: Mon, 22 Aug 2011 17:10:14 -0700
Message-ID: <4E52EFE6.5020004@linux.intel.com>
References: <1314046152-2175-1-git-send-email-andi@firstfloor.org> <1314046152-2175-5-git-send-email-andi@firstfloor.org> <CA5160B4-09CC-4B0D-9AB1-1F946D02B379@dilger.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Andi Kleen <andi@firstfloor.org>, viro@zeniv.linux.org.uk,
	hch@infradead.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Andreas Dilger <adilger@dilger.ca>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mga09.intel.com ([134.134.136.24]:9550 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751204Ab1HWAKP (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 22 Aug 2011 20:10:15 -0400
In-Reply-To: <CA5160B4-09CC-4B0D-9AB1-1F946D02B379@dilger.ca>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


> I think your commit comment is incorrect.  It should read:
>
> Add a generic_file_llseek_size() variant to the VFS that allows passing
> in the maximum file size, instead of always using inode->i_sb->s_maxbytes.
> This can be used to eliminate some cut'n'paste seek code in ext4.
>
> Also, the function prototype in fs.h should take "loff_t maxbytes" instead
> of "loff_t size".

Yes you're right. Will fix.

Thanks for the review.

-Andi