From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [RFC] fs, proc: Introduce the /proc//map_files/ directory v2 Date: Thu, 25 Aug 2011 21:25:23 +0400 Message-ID: <4E568583.40206@parallels.com> References: <20110824085329.GL29452@sun> <20110824111806.GA7191@albatros> <20110825082944.GH10030@sun> <20110825170147.GM2803@mtj.dyndns.org> <4E5680D2.1030608@parallels.com> <20110825172109.GC6387@sun> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Tejun Heo , Vasiliy Kulikov , Nathan Lynch , Oren Laadan , Daniel Lezcano , Andrew Morton , "linux-kernel@vger.kernel.org" , James Bottomley , LINUXFS-ML , "containers@lists.osdl.org" , Zan Lynx , Andi Kleen To: Cyrill Gorcunov Return-path: Received: from mailhub.sw.ru ([195.214.232.25]:36737 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753667Ab1HYRZf (ORCPT ); Thu, 25 Aug 2011 13:25:35 -0400 In-Reply-To: <20110825172109.GC6387@sun> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/25/2011 09:21 PM, Cyrill Gorcunov wrote: > On Thu, Aug 25, 2011 at 09:05:22PM +0400, Pavel Emelyanov wrote: > ... >>> >>> I would prefer if the filename included both start and end addresses >>> so that it matches the first column of /proc/PID/maps and ls'ing the >>> directory is more useful. What do other people think? >> >> Without 0x at the beginning this is not very convenient, but once we add them it no >> longer matches the contents of the /proc/pid/maps. >> >> Just an opinion, do not mind adding to the name. >> > > So Pavel, we can make the names to look as say "3d73a00000-3d73a01000" > leaving proc-inode structure unchanged, that's an idea, right? Not exactly - as I said if we leave the name without 0x (3d000000 instead of 0x3d000000) this makes it hard to use strtol() on these strings to convert names to addresses. Not big deal, just my 5 cents on the "leaving links' names as is" side. > Cyrill > . >