From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: Re: [PATCH] xip: export xip_file_fault Date: Sat, 17 Sep 2011 17:07:21 +0200 Message-ID: <4E74B7A9.1070001@gmail.com> References: <4E749003.30909@gmail.com> <20110917135346.GA31551@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux FS Devel , Linux Kernel To: Christoph Hellwig Return-path: In-Reply-To: <20110917135346.GA31551@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Il 17/09/2011 15:53, Christoph Hellwig ha scritto: > On Sat, Sep 17, 2011 at 02:18:11PM +0200, Marco Stornelli wrote: >> From: Marco Stornelli >> >> There aren't sufficient sync points for a fs for xip operations. In >> particular for the mmap case. It can be not sufficient to lock/unlock >> to do some operation inside get_xip_mem callback. For xip_file_read >> it's really easy to write a fs specific wrapper, xip_file_write hold >> i_mutex so no problem. With this patch it's possible to reuse the >> generic xip_file_fault, using a wrapper function in a fs, without to >> reinvent the wheel. > > As usual please send patches to add exports only while adding callers > for it. > > Actually the module is not currently in mainline even if I hope soon. No problem. I'll resend it at the right moment. Marco