From: Thanh-Lam NGUYEN <thanh-lam.nguyen@alcatel-lucent.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binfmt_elf.c: core file shrinking
Date: Fri, 14 Oct 2011 17:04:16 +0200 [thread overview]
Message-ID: <4E984F70.60102@alcatel-lucent.com> (raw)
In-Reply-To: <CAJd=RBAR6gy2=NFkEAOqH-K+YcUYQKZhsB9YAJi0-TvWFvEKMg@mail.gmail.com>
On 14/10/2011 16:45, Hillf Danton wrote:
> On Fri, Oct 14, 2011 at 4:52 PM, Thanh-Lam NGUYEN
> <thanh-lam.nguyen@alcatel-lucent.com> wrote:
>> Sorry for upping the patch,
>> as it is my first contribution I would like to know if there is any
>> problem with it.
>>
>> Best regard
>> Thanh lam NGUYEN
>>
>> On 11/10/2011 17:36, Thanh-Lam NGUYEN wrote:
>>
>>> The vma_shrink function looks for the 1st allocated and the last
>>> allocated page. Only this part is dumped to the disk (the virual
>>> start address and the size are dupdated to reflect the new dumped
>>> information).
>>>
>>> Signed-off-by: Thanh Lam NGUYEN <thanh-lam.nguyen@alcatel-lucent.com>
>>> Signed-off-by: Benjamin ZORES <Benjamin.Zores@alcatel-lucent.com>
>>> ---
>>> linux/fs/binfmt_elf.c | 54
>>> ++++++++++++++++++++++++++++++++++++++++++++++----
>
> corrupted message?
>
>>> 1 file changed, 55 insertions(+), 4 deletions(-)
>>>
>>> --- linux/fs/binfmt_elf.c
>>> +++ linux/fs/binfmt_elf.c
>>> @@ -1085,6 +1085,48 @@
>>> * Jeremy Fitzhardinge <jeremy@sw.oz.au>
>>> */
>>>
>>> +/*
>>> + * Search for 1st and last allocated page from vma_start to vma_end.
>>> + * Update vma_start and vma_end to reflect the result.
>>> + */
>>> +void vma_shrink(struct vm_area_struct *vma, unsigned long *vma_start,
>>> + unsigned long *vma_end)
>>> +{
>>> + int allocated;
>>> + unsigned long start, addr, end;
>>> +
>>> + allocated = 0;
>>> + start = end = *vma_start;
>>> + for (addr = *vma_start; _addr < *vma_end; addr += PAGE_SIZE) {
> -----^
> where is _addr from?
>
My bad, it's addr and not _addr.
>>> + struct page *page;
>>> + if (get_user_pages(current, current->mm, addr, 1, 0, 1,
>>> + &page, NULL) <= 0) {
>>> + /* NO PAGE */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
=~=~=~=~=~=~=~=~=~=~=~=~==~=~=~=~=~=~=~=~=~=~=~=~=~=~=
Thanh lam NGUYEN
Prestataire externe ALTEN | ALTEN Subcontractor
pour ALCATEL-LUCENT | in ALCATEL-LUCENT
Tel: +333906 77095
Equipe/Team: SWINT
email: tlnguyen@webmail.alten.fr
next prev parent reply other threads:[~2011-10-14 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 15:36 [PATCH] binfmt_elf.c: core file shrinking Thanh-Lam NGUYEN
2011-10-14 8:52 ` Thanh-Lam NGUYEN
2011-10-14 14:45 ` Hillf Danton
2011-10-14 15:04 ` Thanh-Lam NGUYEN [this message]
2011-10-18 7:52 ` Thanh-Lam NGUYEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E984F70.60102@alcatel-lucent.com \
--to=thanh-lam.nguyen@alcatel-lucent.com \
--cc=dhillf@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).