From: Claudio Scordino <claudio@evidence.eu.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
viro@zeniv.linux.org.uk,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] /fs/proc/meminfo.c: fix compilation error
Date: Thu, 17 Nov 2011 09:43:37 +0100 [thread overview]
Message-ID: <4EC4C939.9080401@evidence.eu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111162105400.13603@chino.kir.corp.google.com>
Il 17/11/2011 06:06, David Rientjes ha scritto:
> On Thu, 3 Nov 2011, Claudio Scordino wrote:
>
>> diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
>> index 5861741..80e4645 100644
>> --- a/fs/proc/meminfo.c
>> +++ b/fs/proc/meminfo.c
>> @@ -131,12 +131,13 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
>> K(i.freeswap),
>> K(global_page_state(NR_FILE_DIRTY)),
>> K(global_page_state(NR_WRITEBACK)),
>> - K(global_page_state(NR_ANON_PAGES)
>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> + K(global_page_state(NR_ANON_PAGES)
>> + global_page_state(NR_ANON_TRANSPARENT_HUGEPAGES) *
>> - HPAGE_PMD_NR
>> + HPAGE_PMD_NR),
>> +#else
>> + K(global_page_state(NR_ANON_PAGES)),
>> #endif
>> - ),
>> K(global_page_state(NR_FILE_MAPPED)),
>> K(global_page_state(NR_SHMEM)),
>> K(global_page_state(NR_SLAB_RECLAIMABLE) +
>
> Looks like this needs to be fixed for the per-node sysfs meminfo files as
> well? See node_read_meminfo() in drivers/base/node.c.
Hi David,
that file cannot be compiled for the cris architecture
(therefore, with the compiler that gave me the error) because
CONFIG_NUMA cannot be defined for the cris architecture.
However, I forced make to build also that file, and actually I got the
same error (i.e., "directives may not be used inside a macro argument").
Since Andrew already took the patch for the meminfo.c file, I'm going to
send a further patch for this specific file.
Let me know if instead you prefer to have a single patch for both files.
Best regards,
Claudio
prev parent reply other threads:[~2011-11-17 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 16:27 [PATCH] /fs/proc/meminfo.c: fix compilation error Claudio Scordino
2011-11-17 5:06 ` David Rientjes
2011-11-17 8:43 ` Claudio Scordino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC4C939.9080401@evidence.eu.com \
--to=claudio@evidence.eu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).