linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: syzbot <syzbot+98d3ceb7e01269e7bf4f@syzkaller.appspotmail.com>,
	andriy.shevchenko@linux.intel.com, keescook@chromium.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [hfs?] kernel BUG in hfsplus_show_options
Date: Tue, 18 Jul 2023 21:18:05 -0700	[thread overview]
Message-ID: <4F5F9CC2-803C-4E18-968C-A46B32528F1F@kernel.org> (raw)
In-Reply-To: <0000000000000a88cb0600ccef54@google.com>

On July 18, 2023 6:27:23 PM PDT, syzbot <syzbot+98d3ceb7e01269e7bf4f@syzkaller.appspotmail.com> wrote:
>syzbot has bisected this issue to:
>
>commit c30417b20f4993e49406f3f6d986355c6e943aa2
>Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>Date:   Mon Jul 17 09:33:32 2023 +0000
>
>    seq_file: Replace strncpy()+nul by strscpy()

Uh... Wat. Is this a bug in strscpy fortification? It's copying out of a (recast) be32... It shouldn't expect to find a NUL because it hit the max copy size already...

Looking...

-Kees

>
>bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=17488c1aa80000
>start commit:   aeba456828b4 Add linux-next specific files for 20230718
>git tree:       linux-next
>final oops:     https://syzkaller.appspot.com/x/report.txt?x=14c88c1aa80000
>console output: https://syzkaller.appspot.com/x/log.txt?x=10c88c1aa80000
>kernel config:  https://syzkaller.appspot.com/x/.config?x=e7ec534f91cfce6c
>dashboard link: https://syzkaller.appspot.com/bug?extid=98d3ceb7e01269e7bf4f
>syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15ecf646a80000
>C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1476f30aa80000
>
>Reported-by: syzbot+98d3ceb7e01269e7bf4f@syzkaller.appspotmail.com
>Fixes: c30417b20f49 ("seq_file: Replace strncpy()+nul by strscpy()")
>
>For information about bisection process see: https://goo.gl/tpsmEJ#bisection


-- 
Kees Cook

  reply	other threads:[~2023-07-19  4:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 10:57 [syzbot] [hfs?] kernel BUG in hfsplus_show_options syzbot
2023-07-19  1:27 ` syzbot
2023-07-19  4:18   ` Kees Cook [this message]
     [not found] <566ffabfcc5a7de71205ec4e97245ca2@disroot.org>
2023-07-19 23:17 ` syzbot
     [not found] <e5c7184e93d32d44196e3ac23d88f1fa@disroot.org>
2023-07-19 23:26 ` syzbot
     [not found] <1fa2f7f07ebff31ddc24bbbd9ec47cc9@disroot.org>
2023-07-19 23:52 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5F9CC2-803C-4E18-968C-A46B32528F1F@kernel.org \
    --to=kees@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+98d3ceb7e01269e7bf4f@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).