From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: Re: [PATCH] hfsplus: Fix bless ioctl when used with hardlinks Date: Sat, 14 Apr 2012 14:03:19 +0200 Message-ID: <4F896787.4050108@gmail.com> References: <1334326014-15244-1-git-send-email-mjg@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: hch@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Matthew Garrett Return-path: In-Reply-To: <1334326014-15244-1-git-send-email-mjg@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Il 13/04/2012 16:06, Matthew Garrett ha scritto: > HFS+ doesn't really implement hard links - instead, hardlinks are indicated > by a magic file type which refers to an indirect node in a hidden > directory. The spec indicates that stat() should return the inode number > of the indirect node, but it turns out that this doesn't satisfy the > firmware when it's looking for a bootloader - it wants the catalog ID of > the hardlink file instead. Fix up this case. > > Signed-off-by: Matthew Garrett > --- > fs/hfsplus/ioctl.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/fs/hfsplus/ioctl.c b/fs/hfsplus/ioctl.c > index c640ba5..5ee0681 100644 > --- a/fs/hfsplus/ioctl.c > +++ b/fs/hfsplus/ioctl.c > @@ -31,6 +31,7 @@ static int hfsplus_ioctl_bless(struct file *file, int __user *user_flags) > struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb); > struct hfsplus_vh *vh = sbi->s_vhdr; > struct hfsplus_vh *bvh = sbi->s_backup_vhdr; > + int cnid = (u32)(unsigned long)dentry->d_fsdata; > Why a double cast? Marco