From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Lovenberg Subject: Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call Date: Mon, 16 Apr 2012 15:43:04 -0400 Message-ID: <4F8C7648.8000701@gmail.com> References: <1334316311-22331-1-git-send-email-jlayton@redhat.com> <20120413150518.GA1987@us.ibm.com> <20120413114236.0e557e01@tlielax.poochiereds.net> <4F8B1B7B.3040304@itwm.fraunhofer.de> <20120416073655.7cdb90cf@corrin.poochiereds.net> <4F8C3036.2030702@itwm.fraunhofer.de> <20120416134642.1754cd3e@corrin.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Bernd Schubert , Malahal Naineni , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pstaubach-83r9SdEf25FBDgjK7y7TUQ@public.gmane.org, miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org, viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, michael.brantley-Iq/kdjr4a97QT0dZR+AlfA@public.gmane.org, sven.breuner-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org To: Jeff Layton Return-path: In-Reply-To: <20120416134642.1754cd3e-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On 4/16/2012 1:46 PM, Jeff Layton wrote: > NFS will generally return a different error if the process catches a > fatal signal, so a soft mount should not be necessary and is not > recommended anyway... > > In any case, we loop indefinitely now in the NFS code when (for > instance) there's a loss of communication. Users are not generally > happy if that causes an error, since their applications start dying. > From the peanut gallery, I've always set an infinite loop with an exponential backoff on the loss of communication. IE, in some code I wrote for S3backer (a FUSE file system on top of Amazon EC3) a few years ago (committed by Archie Cobbs). The trade off is that your applications will try to submit requests if you don't tell them "leave me alone, I can't service you now". The more I think about it, the more it seems like failing silently. Isn't the rule supposed to be "if you must fail, do it loudly and as soon as possible"? Just my $0.02. Take it as you will. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html