From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: Zheng Liu <gnehzuil.liu@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [RFC][PATCH 0/3] add FALLOC_FL_NO_HIDE_STALE flag in fallocate
Date: Wed, 18 Apr 2012 09:57:10 -0500 [thread overview]
Message-ID: <4F8ED646.1040100@redhat.com> (raw)
In-Reply-To: <D225F088-A53F-4962-97AD-13C850BBA722@whamcloud.com>
On 4/17/12 11:59 PM, Andreas Dilger wrote:
...
> Secondly, your test program is not doing random writes to disk, but
> rather doing writes at 64kB intervals. There is logic in the
> uninitialized extent handling that will write zeros to an entire
> extent, rather than create many fragmented uninitialized extents. It
> may be possible that you are zeroing out the entire file, and writing
> 16x as much data as you expect.
>
> Cheers, Andreas
I don't think the testcase as written is triggering that behavior, though
other similar testcases might. In this case the left-over uninit extents
are large enough that they don't get zeroed:
File size of /mnt/scratch/test is 268435456 (65536 blocks, blocksize 4096)
ext logical physical expected length flags
0 0 34816 1
1 1 34817 15 unwritten
2 16 34832 1
3 17 34833 15 unwritten
4 32 34848 1
5 33 34849 15 unwritten
...
Good guess though :)
-Eric
next prev parent reply other threads:[~2012-04-18 14:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 16:53 [RFC][PATCH 0/3] add FALLOC_FL_NO_HIDE_STALE flag in fallocate Zheng Liu
2012-04-17 16:53 ` [RFC][PATCH 1/3] vfs: " Zheng Liu
2012-04-17 16:53 ` [RFC][PATCH 2/3] vfs: add security check for _NO_HIDE_STALE flag Zheng Liu
2012-04-17 16:53 ` [RFC][PATCH 3/3] ext4: add FALLOC_FL_NO_HIDE_STALE support Zheng Liu
2012-04-17 17:40 ` [RFC][PATCH 0/3] add FALLOC_FL_NO_HIDE_STALE flag in fallocate Eric Sandeen
2012-04-18 4:08 ` Zheng Liu
2012-04-18 7:48 ` Lukas Czerner
2012-04-18 12:03 ` Zheng Liu
2012-04-18 12:07 ` Lukas Czerner
2012-04-20 9:52 ` Zheng Liu
2012-04-18 4:59 ` Andreas Dilger
2012-04-18 8:19 ` Lukas Czerner
2012-04-18 12:48 ` Zheng Liu
2012-04-18 15:09 ` Andreas Dilger
2012-04-20 9:59 ` Zheng Liu
2012-04-18 11:38 ` Zheng Liu
2012-04-18 11:39 ` Lukas Czerner
2012-04-18 12:06 ` Zheng Liu
2012-04-18 14:57 ` Eric Sandeen [this message]
2012-04-17 17:59 ` Ric Wheeler
2012-04-17 18:43 ` Ted Ts'o
2012-04-17 18:52 ` Ric Wheeler
2012-04-17 18:53 ` Eric Sandeen
2012-04-17 19:04 ` Ted Ts'o
2012-04-18 3:02 ` Dave Chinner
2012-04-18 16:07 ` Ted Ts'o
2012-04-18 23:37 ` Dave Chinner
2012-04-18 8:04 ` Lukas Czerner
-- strict thread matches above, loose matches on Subject: below --
2012-04-23 1:55 Szabolcs Szakacsits
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8ED646.1040100@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@whamcloud.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).