From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH RFC v3] vfs: make fstatat retry once on ESTALE errors from getattr call Date: Fri, 20 Apr 2012 16:18:37 -0400 Message-ID: <4F91C49D.8070908@RedHat.com> References: <1334316311-22331-1-git-send-email-jlayton@redhat.com> <1334749927-26138-1-git-send-email-jlayton@redhat.com> <20120420104055.511e15bc@tlielax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org, viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, michael.brantley-Iq/kdjr4a97QT0dZR+AlfA@public.gmane.org, sven.breuner-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org, chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, pstaubach-83r9SdEf25FBDgjK7y7TUQ@public.gmane.org, malahal-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org, trond.myklebust-41N18TsMXrtuMpJDpNschA@public.gmane.org, rees-63aXycvo3TyHXe+LvDLADg@public.gmane.org To: Jeff Layton Return-path: In-Reply-To: <20120420104055.511e15bc-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On 04/20/2012 10:40 AM, Jeff Layton wrote: > I guess the questions at this point is: > > 1) How representative is Peter's mkdir_test() of a real-world workload? Reading your email I had to wonder the same thing... What application removes hierarchy of directories in a loop from two different clients? I would suspect not many, if any... esp over NFS... > > 2) if we assume that it is fairly representative of one, how can we > achieve retrying indefinitely with NFS, or at least some large finite > amount? The amount of looping would be peer speculation. If the problem can not be handled by one simple retry I would say we simply pass the error up to the app... Its an application issue... > > I have my doubts as to whether it would really be as big a problem for > other filesystems as Miklos and others have asserted, but I'll take > their word for it at the moment. What's the best way to contain this > behavior to just those filesystems that want to retry indefinitely when > they get an ESTALE? Would we need to go with an entirely new > ESTALERETRY after all? > Introducing a new errno to handle this problem would be overkill IMHO... If we have to go to the looping approach, I would strong suggest we make the file systems register for this type of behavior... steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html