linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: jack@suse.cz
Subject: [PATCH]: Remove redundant underlying file system checking that the quota files resides from dquot_quota_on()
Date: Sun, 22 Apr 2012 14:16:13 +0800	[thread overview]
Message-ID: <4F93A22D.300@oracle.com> (raw)

Hi Jan,

When executing quotaon(8), all the file systems(ext3/ext4/reiserfs) binded to the VFS quota framework have
already ensured that the quota files are resides on the same file system with the specified super block
before invoking dquot_quota_on(), looks like we can be safely remove it from there IMHO.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>

---
 fs/quota/dquot.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 4674197..cb917a2 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2199,13 +2199,10 @@ int dquot_quota_on(struct super_block *sb, int type, int format_id,
 	int error = security_quota_on(path->dentry);
 	if (error)
 		return error;
-	/* Quota file not on the same filesystem? */
-	if (path->dentry->d_sb != sb)
-		error = -EXDEV;
-	else
-		error = vfs_load_quota_inode(path->dentry->d_inode, type,
-					     format_id, DQUOT_USAGE_ENABLED |
-					     DQUOT_LIMITS_ENABLED);
+
+	error = vfs_load_quota_inode(path->dentry->d_inode, type,
+				     format_id, DQUOT_USAGE_ENABLED |
+				     DQUOT_LIMITS_ENABLED);
 	return error;
 }
 EXPORT_SYMBOL(dquot_quota_on);
-- 
1.7.9

             reply	other threads:[~2012-04-22 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-22  6:16 Jeff Liu [this message]
2012-04-23  7:44 ` [PATCH]: Remove redundant underlying file system checking that the quota files resides from dquot_quota_on() Jan Kara
2012-04-23  0:02   ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F93A22D.300@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).