From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [patch 0/5] refault distance-based file cache sizing Date: Tue, 01 May 2012 17:19:16 -0400 Message-ID: <4FA05354.8000304@redhat.com> References: <1335861713-4573-1-git-send-email-hannes@cmpxchg.org> <20120501120819.0af1e54b.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Johannes Weiner , linux-mm@kvack.org, Andrea Arcangeli , Peter Zijlstra , Mel Gorman , Minchan Kim , Hugh Dickins , KOSAKI Motohiro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Morton Return-path: In-Reply-To: <20120501120819.0af1e54b.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 05/01/2012 03:08 PM, Andrew Morton wrote: > On Tue, 1 May 2012 10:41:48 +0200 > Johannes Weiner wrote: > >> This series stores file cache eviction information in the vacated page >> cache radix tree slots and uses it on refault to see if the pages >> currently on the active list need to have their status challenged. > > So we no longer free the radix-tree node when everything under it has > been reclaimed? One could create workloads which would result in a > tremendous amount of memory used by radix_tree_node_cachep objects. > > So I assume these things get thrown away at some point. Some > discussion about the life-cycle here would be useful. I assume that in the current codebase Johannes has, we would have to rely on the inode cache shrinker to reclaim the inode and throw out the radix tree nodes. Having a better way to deal with radix tree nodes that contain stale entries (where the evicted pages would no longer receive special treatment on re-fault, because it has been so long) get reclaimed would be nice for a future version. Probably not too urgent, though... -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org