linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: linux-fsdevel@vger.kernel.org
Subject: Fwd: [PATCH] fix minixfs block limit check
Date: Wed, 09 May 2012 23:58:29 +0200	[thread overview]
Message-ID: <4FAAE885.2030908@gmail.com> (raw)
In-Reply-To: <4FAACF55.5070809@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]


Since it was ignored on LKML, I guess this should be the right place to
send this patch to.

-------- Original Message --------
Subject: 	[PATCH] fix minixfs block limit check
Date: 	Wed, 09 May 2012 22:11:01 +0200
From: 	Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>
To: 	linux-kernel@vger.kernel.org



Hello, all. On minix2 and minix3 usually max_size is 7fffffff and the
check in question prohibits creation of last block spanning right before
7fffffff. Here is a fix:

--- fs/minix/itree_v2.c    2011-04-23 01:34:36.363725380 +0200
+++ /home/phcoder/projects/fs/minix/itree_v2.c    2012-05-09
21:47:52.335621065 +0200
@@ -32,7 +32,8 @@
     if (block < 0) {
         printk("MINIX-fs: block_to_path: block %ld < 0 on dev %s\n",
             block, bdevname(sb->s_bdev, b));
-    } else if (block >=
(minix_sb(inode->i_sb)->s_max_size/sb->s_blocksize)) {
+    } else if ((u64) block * (u64) sb->s_blocksize
+           >= minix_sb(inode->i_sb)->s_max_size) {
         if (printk_ratelimit())
             printk("MINIX-fs: block_to_path: "

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko






[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

           reply	other threads:[~2012-05-09 21:58 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <4FAACF55.5070809@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAAE885.2030908@gmail.com \
    --to=phcoder@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).