From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [rfc 2/4] procfs: Convert /proc/pid/fdinfo/fd handling routines into seq-file with fdinfo helpers Date: Thu, 17 May 2012 20:32:04 +0400 Message-ID: <4FB52804.8090004@parallels.com> References: <20120517160738.116113099@openvz.org> <20120517162534.681059644@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "linux-kernel@vger.kernel.org" , Andrew Morton , James Bottomley , "linux-fsdevel@vger.kernel.org" To: Cyrill Gorcunov Return-path: In-Reply-To: <20120517162534.681059644@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 05/17/2012 08:07 PM, Cyrill Gorcunov wrote: > This patch converts /proc/pid/fdinfo/fd handling routines to seq-files with > ability to plug in additional fdinfo helpers from other subsystems. > > For example files created in eventfd/eventpoll/inotify subsystems might print > out additional information, not just file position and flags. > > Still if there no fdinfo helpers registered then the output is well known > pos, flags pair. > > Signed-off-by: Cyrill Gorcunov I would split this into two parts -- the 1st one turns fdinfo into seq-files and the 2nd one adds the fdinfo helpers. This will make the review MUCH simpler. Thanks, Pavel