From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Liu Subject: Re: [PATCH 10/12] container quota: bill container inodes alloc/free on ext4. Date: Thu, 31 May 2012 11:24:25 +0800 Message-ID: <4FC6E469.2040405@oracle.com> References: <1338389946-13711-1-git-send-email-jeff.liu@oracle.com> <1338389946-13711-11-git-send-email-jeff.liu@oracle.com> <20120530155543.GB13236@thunk.org> <4FC6CCB6.4090908@oracle.com> <20120531015453.GA6759@thunk.org> <4FC6D94D.6040106@oracle.com> Reply-To: jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jack-AlSwsSmVLrQ@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, bpm-sJ/iWh9BUns@public.gmane.org, christopher.jones-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tm-d1IQDZat3X0@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, chris.mason-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, tinguely-sJ/iWh9BUns@public.gmane.org To: "Ted Ts'o" Return-path: In-Reply-To: <4FC6D94D.6040106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On 05/31/2012 10:37 AM, Jeff Liu wrote: > On 05/31/2012 09:54 AM, Ted Ts'o wrote: > >> On Thu, May 31, 2012 at 09:43:18AM +0800, Jeff Liu wrote: >>> I also think that is stupid to change all of the file systems with those >>> hook routines. >>> At first I have tried to change the quota layer by adding >>> ns_dquot_() to the corresponding dquot_(), it could works on >>> ext4, and it should works on other file systems which are tightly bound >>> to VFS quota IMHO. >>> >>> However, XFS has its own quota management subsystem, with looser binding >>> to VFS quota. That's why am trying to export those routines over all >>> the file systems and CC to the maintainers, sorry for the noise. >> >> No worries about the noise. I was just trying to suggest something >> that might be easier for you. >> >> As near as I can tell XFS doesn't use the fs/quota functions at all, >> yes? But if you add it into the fs/quota functions, it should get you >> integration with ext2, ext3, ext4, jfs, ocfs2, and reiserfs. Yes? > > Yes, I just took a quick look through over ocfs2, reiserfs and jfs, they > are all ok. Such being the case, maybe I should tight ns_dquot_() to VFS quota to reduce duplication firstly, at lease, it could works with most file systems. Then consider another way to let it works with other file systems doesn't use fs/quota. Thanks, -Jeff > > Thanks, > -Jeff > >> >> - Ted >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html