linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Xin Zhao" <uszhaoxin@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: linux-fsdevel@vger.kernel.org
Subject: NFS implementation redundancy
Date: Tue, 30 May 2006 18:27:48 -0400	[thread overview]
Message-ID: <4ae3c140605301527r59e91f9ah20dde8a4ae812d0e@mail.gmail.com> (raw)

Hi,

I am looking at NFS implementation included in kernel 2.6.16. In
nfs/inode.c, function nfs_delete_inode() called nfs_wb_all() after
truncate_inode_pages(). However, truncate_inode_pages is supposed to
flush out pages, why do we still need nfs_wb_all()? Moreover, after
this nfs_wb_all,  function nfs_delete_inode() immediately calls
clear_inode(), which will call nfs_wb_all() again.

This looks redundant to me. Any explaination on this?

Thanks,
Xin

                 reply	other threads:[~2006-05-30 22:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ae3c140605301527r59e91f9ah20dde8a4ae812d0e@mail.gmail.com \
    --to=uszhaoxin@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).