From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xin Zhao" Subject: NFS implementation redundancy Date: Tue, 30 May 2006 18:27:48 -0400 Message-ID: <4ae3c140605301527r59e91f9ah20dde8a4ae812d0e@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from wr-out-0506.google.com ([64.233.184.237]:57274 "EHLO wr-out-0506.google.com") by vger.kernel.org with ESMTP id S932525AbWE3W1w (ORCPT ); Tue, 30 May 2006 18:27:52 -0400 Received: by wr-out-0506.google.com with SMTP id i21so775428wra for ; Tue, 30 May 2006 15:27:51 -0700 (PDT) To: linux-kernel Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, I am looking at NFS implementation included in kernel 2.6.16. In nfs/inode.c, function nfs_delete_inode() called nfs_wb_all() after truncate_inode_pages(). However, truncate_inode_pages is supposed to flush out pages, why do we still need nfs_wb_all()? Moreover, after this nfs_wb_all, function nfs_delete_inode() immediately calls clear_inode(), which will call nfs_wb_all() again. This looks redundant to me. Any explaination on this? Thanks, Xin