From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 735D779D3 for ; Wed, 26 Jun 2024 00:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719362233; cv=none; b=neFSOireTzWg6p34psp1vNV6Mnq/4nFYY+L41kn3/zsmYJNfT5/h7oJv42/REv+PWZPqXfXg2CVBfujWazKDyHetAP26Op9uWy4Fp1l2spnxRk22QbYd3KAgG7f0feKPQowhKI1Z51A4fWW3FIeYGBmXvtdBdDWhUjvNgGGdGi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719362233; c=relaxed/simple; bh=S+YCG6Gtni5r+dPZPXoehUVpJrUKGN5ylG+dZOH2LZs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h9x7BhLb0LBwcBRcAEnLZpQnPmi+6K/fQ98XG/d+01/bWHbCDrrbBTkhK6D3SnPr/dvachPWtZvQ3D+GFeiQ2PjzCasmElMFr1q5YWdsPx0viLDKqMfAJaprgEgVK5a21kgVI91drohGn+hd8KmcskZFf0+UfczpgAp9oI5dGSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CG6CcWs3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CG6CcWs3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719362230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7XSa6ZpfJ2JlPT3g8OgBf9PZ5iAj39OSQpGesaTNmpY=; b=CG6CcWs3D4w4x6rrDahtBJLeWWVbPIakmot5v+E7cNbC97ViuCp28eNWe8ThXitKxFJh1a 7gcOOIlKVnmecbPrMTnJSVMvW1dRNjye8XR7X4u0Q9nwpKdOgqEBYSJJssCF+J6TPKb8KR 72s51n523j8rmaDZ66Duo+jeIyzL0Co= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-VIgVh1AMMLypD7wjQkX-2Q-1; Tue, 25 Jun 2024 20:37:08 -0400 X-MC-Unique: VIgVh1AMMLypD7wjQkX-2Q-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2c7a6c639bfso7765339a91.3 for ; Tue, 25 Jun 2024 17:37:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719362227; x=1719967027; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7XSa6ZpfJ2JlPT3g8OgBf9PZ5iAj39OSQpGesaTNmpY=; b=e9OxDCyQkiaAodrug9K0D/k4t/kcSAQd5sX4AEZE+pnPy8CvHDIqG1loyA9VkPkAwx 8p/R5h+j6taiqzHcu/yh7q0T9Y7AYGstJIdhoKO1kTae3PtKaowF3VUZE7L1cLbmyFIn FSBNRpna5H9FSClz7Ki4sf0PhY1AcHtMbiKgXJhPxd810kjcqnvKFH3kInai0oBg8MAF ufrkQCcl2tGQMzYlqTKYLfIoisK/JvQuau8meH5AinfHUho8Rw+S6hUlcnnYDl2Z6WQC 7B4BYQYEpQOr5eXNMJB+x+TxoqvLMGxu8fvw3wX4NQXWH0qEVBwXfP/F/PjP7v1OidVa sxeQ== X-Forwarded-Encrypted: i=1; AJvYcCWMYzOTyAJ9RcLWoGQpsL/M/aGNY4M+twjIFBZb4WSChdlJZOI5ywPLzDLsBLATSM3WjzUScCH5zPawrjUSqMwS7Y0N7DMtFsc3fITdWg== X-Gm-Message-State: AOJu0Yyk4ES8qb9DRRU9P768hWFRgoAmMO/bqEWONtxaDEZAc1fHnVjC nuZ0MPJSzBaz8nzgLOyHVwSgKPIsGrYF+Afc0riHV8+ZyR03dKSiLejpdNGY59HlHYrpMciKY8m mN1iXN8/thkVXVba6rkvNIYMu8J0EG/aTWXCatu4cmu58txcWdR+Yj3gTp3ch1kg= X-Received: by 2002:a17:902:ecc8:b0:1f9:c289:737c with SMTP id d9443c01a7336-1fa1d683c1emr106652815ad.60.1719362227390; Tue, 25 Jun 2024 17:37:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDjNcz0viQEwIaipBp6N0yRlPUsIKoKAYuglwG9H2KqNectD+G314m4fAwmTDdbJQL9ffogQ== X-Received: by 2002:a17:902:ecc8:b0:1f9:c289:737c with SMTP id d9443c01a7336-1fa1d683c1emr106652695ad.60.1719362226970; Tue, 25 Jun 2024 17:37:06 -0700 (PDT) Received: from [192.168.68.50] ([43.252.112.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb3c6ec0sm88110985ad.169.2024.06.25.17.37.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 17:37:06 -0700 (PDT) Message-ID: <4b05bdae-22e8-4906-b255-5edd381b3d21@redhat.com> Date: Wed, 26 Jun 2024 10:37:00 +1000 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] mm/filemap: Limit page cache size to that supported by xarray To: David Hildenbrand , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, djwong@kernel.org, willy@infradead.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com References: <20240625090646.1194644-1-gshan@redhat.com> <20240625113720.a2fa982b5cb220b1068e5177@linux-foundation.org> <33d9e4b3-4455-4431-81dc-e621cf383c22@redhat.com> <20240625115855.eb7b9369c0ddd74d6d96c51e@linux-foundation.org> Content-Language: en-US From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/26/24 5:05 AM, David Hildenbrand wrote: > On 25.06.24 20:58, Andrew Morton wrote: >> On Tue, 25 Jun 2024 20:51:13 +0200 David Hildenbrand wrote: >> >>>> I could split them and feed 1&2 into 6.10-rcX and 3&4 into 6.11-rc1.  A >>>> problem with this approach is that we're putting a basically untested >>>> combination into -stable: 1&2 might have bugs which were accidentally >>>> fixed in 3&4.  A way to avoid this is to add cc:stable to all four >>>> patches. >>>> >>>> What are your thoughts on this matter? >>> >>> Especially 4 should also be CC stable, so likely we should just do it >>> for all of them. >> >> Fine.  A Fixes: for 3 & 4 would be good.  Otherwise we're potentially >> asking for those to be backported further than 1 & 2, which seems >> wrong. > > 4 is shmem fix, which likely dates back a bit longer. > >> >> Then again, by having different Fixes: in the various patches we're >> suggesting that people split the patch series apart as they slot things >> into the indicated places.  In other words, it's not a patch series at >> all - it's a sprinkle of independent fixes.  Are we OK thinking of it >> in that fashion? > > The common themes is "pagecache cannot handle > order-11", #1-3 tackle "ordinary" file THP, #4 tackles shmem THP. > > So I'm not sure we should be splitting it apart. It's just that shmem THP arrived before file THP :) > I rechecked the history, it's a bit hard to have precise fix tag for PATCH[4]. Please let me know if you have a better one for PATCH[4]. #4 Fixes: 800d8c63b2e9 ("shmem: add huge pages support") Cc: stable@kernel.org # v4.10+ Fixes: 552446a41661 ("shmem: Convert shmem_add_to_page_cache to XArray") Cc: stable@kernel.org # v4.20+ #3 Fixes: 793917d997df ("mm/readahead: Add large folio readahead") Cc: stable@kernel.org # v5.18+ #2 Fixes: 4687fdbb805a ("mm/filemap: Support VM_HUGEPAGE for file mappings") Cc: stable@kernel.org # v5.18+ #1 Fixes: 793917d997df ("mm/readahead: Add large folio readahead") Cc: stable@kernel.org # v5.18+ I probably need to move PATCH[3] before PATCH[2] since PATCH[1] and PATCH[2] point to same commit. Thanks, Gavin