From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42012 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752435AbcHRIpT (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 18 Aug 2016 04:45:19 -0400
Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef
 __USE_FILE_OFFSET64
To: Andreas Schwab <schwab@linux-m68k.org>
References: <1471445251-2450-1-git-send-email-jlayton@redhat.com>
 <024779d0-2800-8e43-b65c-180eca70cc8b@redhat.com>
 <1471455596.3196.36.camel@redhat.com>
 <a2cb8cef-26d6-fdb4-9071-e1ed8502d7ae@redhat.com>
 <1471458074.3196.67.camel@redhat.com>
 <9a96f830-ad56-91fe-1293-1d38d9195e49@redhat.com>
 <87ziobt8xj.fsf@linux-m68k.org>
Cc: Jeff Layton <jlayton@redhat.com>, libc-alpha@sourceware.org,
	linux-fsdevel@vger.kernel.org,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	"Carlos O'Donell" <carlos@redhat.com>,
	Yuriy Kolerov <Yuriy.Kolerov@synopsys.com>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <4b4a2f9e-c6eb-c9f0-51bb-8f2ea5471f21@redhat.com>
Date: Thu, 18 Aug 2016 10:45:15 +0200
MIME-Version: 1.0
In-Reply-To: <87ziobt8xj.fsf@linux-m68k.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 08/17/2016 10:52 PM, Andreas Schwab wrote:
> On Aug 17 2016, Florian Weimer <fweimer@redhat.com> wrote:
>
>> Why would the F_SETLK operation work with a struct flock64 in
>> _FILE_OFFSET_BITS == 64 mode?  I think the kernel still expects a 32-bit
>> struct.
>
> With _F_O_B == 64, F_SETLK is actually F_SETLK64.

Indeed, I missed that.  I think removing the file-private lock 
definitions in 32 bit mode is the closest we can get to mirror this 
behavior.

Florian