Re: [PATCH v12 resend 0/1] fs: Add VirtualBox guest shared folder (vboxsf)

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 8/11/19 5:31 PM, Randy Dunlap wrote:
> On 8/11/19 8:16 AM, Randy Dunlap wrote:
>> On 8/11/19 8:09 AM, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 8/11/19 5:07 PM, Randy Dunlap wrote:
>>>> On 8/11/19 6:38 AM, Hans de Goede wrote:
>>>>> Hello Everyone,
>>>>>
>>>>> Here is a resend of the 12th version of my cleaned-up / refactored version
>>>>> of the VirtualBox shared-folder VFS driver. It seems that for some reason
>>>>> only the cover letter of my initial-posting of v12 has made it to the list.
>>>>>
>>>>> This version hopefully addresses all issues pointed out in David Howell's
>>>>> review of v11 (thank you for the review David):
>>>>>
>>>>> Changes in v12:
>>>>> -Move make_kuid / make_kgid calls to option parsing time and add
>>>>>    uid_valid / gid_valid checks.
>>>>> -In init_fs_context call current_uid_gid() to init uid and gid
>>>>> -Validate dmode, fmode, dmask and fmask options during option parsing
>>>>> -Use correct types for various mount option variables (kuid_t, kgid_t, umode_t)
>>>>> -Some small coding-style tweaks
>>>>>
>>>>> For changes in older versions see the change log in the patch.
>>>>>
>>>>> This version has been used by several distributions (arch, Fedora) for a
>>>>> while now, so hopefully we can get this upstream soonish, please review.
>>>>
>>>> Hi,
>>>> Still looks like patch 1/1 is not hitting the mailing list.
>>>> How large is it?
>>>
>>> Thank you for catching this:
>>>
>>> [hans@dhcp-44-196 linux]$ wc 0001-fs-Add-VirtualBox-guest-shared-folder-vboxsf-support.patch
>>>    3754  14479 100991 0001-fs-Add-VirtualBox-guest-shared-folder-vboxsf-support.patch
>>
>> That size shouldn't be a problem AFAIK.
>> Maybe there is something else in the patch that vger doesn't like.
>>
>>    http://vger.kernel.org/majordomo-taboos.txt
>>
> 
> "Message size exceeding 100 000 characters causes blocking."
> from:  http://vger.kernel.org/majordomo-info.html
> 
> I thought the limit was higher than that.

Thank you for this info. I've trimmed the changelog below the ---
in the commit messages, moving it to the coverletter, this
brings the size down to aprox. 96000 chars and I've done another
resend. Can you please let me know (offlist) if this one has
successfully made it to the list?

Regards,

Hans