From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel Phillips" Subject: Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c Date: Sun, 28 Oct 2007 19:57:47 -0700 Message-ID: <4d47a5d10710281957g1e423c1q6f45415d7465d90@mail.gmail.com> References: <11935266454097-git-send-email-ezk@cs.sunysb.edu> <11935266451616-git-send-email-ezk@cs.sunysb.edu> <20071028141222.GA29323@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Erez Zadok" , viro@ftp.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "Christoph Hellwig" Return-path: Received: from smtp-out.google.com ([216.239.45.13]:40619 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbXJ2C5u (ORCPT ); Sun, 28 Oct 2007 22:57:50 -0400 Received: from zps19.corp.google.com (zps19.corp.google.com [172.25.146.19]) by smtp-out.google.com with ESMTP id l9T2vm4g030694 for ; Sun, 28 Oct 2007 19:57:48 -0700 Received: from nz-out-0506.google.com (nzcx7.prod.google.com [10.36.125.7]) by zps19.corp.google.com with ESMTP id l9T2vlin026979 for ; Sun, 28 Oct 2007 19:57:47 -0700 Received: by nz-out-0506.google.com with SMTP id x7so1051115nzc for ; Sun, 28 Oct 2007 19:57:47 -0700 (PDT) In-Reply-To: <20071028141222.GA29323@infradead.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 10/28/07, Christoph Hellwig wrote: > While you're at it, it's probably worth splitting this out into > a small helper function. Why? Is the same pattern called from more than one place? Regards, Daniel