From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Blunck" Subject: Re: [RFC][PATCH 14/14] tmpfs whiteout support Date: Mon, 14 May 2007 21:20:53 +0200 Message-ID: <4de7f8a60705141220j2764f326u69545490cdd23c08@mail.gmail.com> References: <20070514093722.GB4139@in.ibm.com> <20070514094519.GP4139@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Bharata B Rao" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Jan Blunck" To: "Hugh Dickins" Return-path: Received: from an-out-0708.google.com ([209.85.132.246]:11067 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754761AbXENTUy (ORCPT ); Mon, 14 May 2007 15:20:54 -0400 Received: by an-out-0708.google.com with SMTP id d18so445700and for ; Mon, 14 May 2007 12:20:53 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 5/14/07, Hugh Dickins wrote: > On Mon, 14 May 2007, Bharata B Rao wrote: > > From: Jan Blunck > > Subject: tmpfs whiteout support > > > > Introduce whiteout support to tmpfs. > > > > Signed-off-by: Jan Blunck > > Signed-off-by: Bharata B Rao > > --- > > mm/shmem.c | 9 ++++++++- > > 1 files changed, 8 insertions(+), 1 deletion(-) > > > > --- a/mm/shmem.c > > +++ b/mm/shmem.c > > @@ -74,7 +74,7 @@ > > #define LATENCY_LIMIT 64 > > > > /* Pretend that each entry is of this size in directory's i_size */ > > -#define BOGO_DIRENT_SIZE 20 > > +#define BOGO_DIRENT_SIZE 1 > > Why would that change be needed for whiteout support? > Good question. It seems that this a survivor of the changes necessary for union readdir. This isn't necessary for white-outs. BTW: Why do we claim this to be 20??? Is there any meaning behind this? Cheers, Jan