public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Bernd Schubert <bschubert@ddn.com>, Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fuse: Increase FUSE_NAME_MAX to PATH_MAX
Date: Fri, 13 Dec 2024 09:53:58 +0800	[thread overview]
Message-ID: <4e94f0db-2f96-4f38-9d48-b4d2389bef2f@linux.alibaba.com> (raw)
In-Reply-To: <20241212-fuse_name_max-limit-6-13-v1-2-92be52f01eca@ddn.com>



On 12/13/24 5:50 AM, Bernd Schubert wrote:
> Our file system has a translation capability for S3-to-posix.
> The current value of 1kiB is enough to cover S3 keys, but
> does not allow encoding of escape characters. The limit is
> increased by factor 3 to allow worst case encoding with %xx.
> 
> Testing large file names was hard with libfuse/example file systems,
> so I created a new memfs that does not have a 255 file name length
> limitation.
> https://github.com/libfuse/libfuse/pull/1077
> 
> Signed-off-by: Bernd Schubert <bschubert@ddn.com>
> ---
>  fs/fuse/fuse_i.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
> index 74744c6f286003251564d1235f4d2ca8654d661b..91b4cdd60fd4fe4ca5c3b8f2c9e5999c69d40690 100644
> --- a/fs/fuse/fuse_i.h
> +++ b/fs/fuse/fuse_i.h
> @@ -39,7 +39,7 @@
>  #define FUSE_NOWRITE INT_MIN
>  
>  /** It could be as large as PATH_MAX, but would that have any uses? */
> -#define FUSE_NAME_MAX 1024
> +#define FUSE_NAME_MAX (3 * 1024)


So why not increase it directly to PATH_MAX, as indicated by the comment?

-- 
Thanks,
Jingbo

  reply	other threads:[~2024-12-13  1:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 21:50 [PATCH 0/2] fuse: Increase FUSE_NAME_MAX limit Bernd Schubert
2024-12-12 21:50 ` [PATCH 1/2] fuse: Allocate only namelen buf memory in fuse_notify_ Bernd Schubert
2024-12-13  1:51   ` Jingbo Xu
2024-12-12 21:50 ` [PATCH 2/2] fuse: Increase FUSE_NAME_MAX to PATH_MAX Bernd Schubert
2024-12-13  1:53   ` Jingbo Xu [this message]
2024-12-13  9:17   ` Shachar Sharon
2024-12-13 10:34     ` Bernd Schubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e94f0db-2f96-4f38-9d48-b4d2389bef2f@linux.alibaba.com \
    --to=jefflexu@linux.alibaba.com \
    --cc=bschubert@ddn.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox