linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Asias He <asias@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	linux-kernel@vger.kernel.org, linux-aio@kvack.org,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	virtualization@lists.linux-foundation.org,
	Benjamin LaHaise <bcrl@kvack.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/5] Add vhost-blk support
Date: Tue, 17 Jul 2012 11:32:45 +0200	[thread overview]
Message-ID: <5005313D.1000300@redhat.com> (raw)
In-Reply-To: <50052E7E.6020100@redhat.com>

Il 17/07/2012 11:21, Asias He ha scritto:
>> It depends.  Like vhost-scsi, vhost-blk has the problem of a crippled
>> feature set: no support for block device formats, non-raw protocols,
>> etc.  This makes it different from vhost-net.
> 
> Data-plane qemu also has this cripppled feature set problem, no?

Yes, but that is just a proof of concept.  We can implement a separate
I/O thread within the QEMU block layer, and add fast paths that resemble
data-path QEMU, without limiting the feature set.

> Does user always choose to use block devices format like qcow2? What
> if they prefer raw image or raw block device?

If they do, the code should hit fast paths and be fast.  But it should
be automatic, without the need for extra knobs.  aio=thread vs.
aio=native is already one knob too much IMHO.

>> So it begs the question, is it going to be used in production, or just a
>> useful reference tool?
> 
> This should be decided by user, I can not speak for them. What is wrong
> with adding one option for user which they can decide?

Having to explain the user about the relative benefits; having to
support the API; having to handle transition from one more thing when
something better comes out.

Paolo

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

  reply	other threads:[~2012-07-17  9:32 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 15:35 [PATCH 0/5] Add vhost-blk support Asias He
2012-07-12 15:35 ` [PATCH 1/5] aio: Export symbols and struct kiocb_batch for in kernel aio usage Asias He
2012-07-12 17:50   ` James Bottomley
2012-07-13  1:40     ` Asias He
2012-07-12 16:06 ` [PATCH 0/5] Add vhost-blk support Jeff Moyer
2012-07-13  1:19   ` Asias He
2012-07-16 11:58 ` Stefan Hajnoczi
2012-07-17  8:29   ` Asias He
2012-07-17  8:52     ` Paolo Bonzini
2012-07-17  9:21       ` Asias He
2012-07-17  9:32         ` Paolo Bonzini [this message]
2012-07-17  9:51           ` Michael S. Tsirkin
2012-07-17 11:11         ` Stefan Hajnoczi
2012-07-17 11:26           ` Michael S. Tsirkin
2012-07-17 11:42             ` Stefan Hajnoczi
2012-07-17 11:51               ` Stefan Hajnoczi
2012-07-17 11:54               ` Michael S. Tsirkin
2012-07-17 12:03                 ` Stefan Hajnoczi
2012-07-17 12:48                   ` Michael S. Tsirkin
2012-07-17 13:02                     ` Paolo Bonzini
2012-07-17 13:26                       ` Michael S. Tsirkin
2012-07-18  8:47                       ` Asias He
2012-07-18  8:12           ` Asias He
2012-07-18  8:26             ` Stefan Hajnoczi
2012-07-18  9:46         ` Ronen Hod
2012-07-17  9:45       ` Michael S. Tsirkin
2012-07-17 10:14         ` Paolo Bonzini
2012-07-17 10:49           ` Michael S. Tsirkin
2012-07-17 10:56             ` Paolo Bonzini
2012-07-17 11:09               ` Michael S. Tsirkin
2012-07-17 11:36     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5005313D.1000300@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=asias@redhat.com \
    --cc=bcrl@kvack.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=stefanha@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).