From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [git pull] vfs.git; pile 1 Date: Mon, 23 Jul 2012 19:54:51 +0300 Message-ID: <500D81DB.3040505@panasas.com> References: <20120722100920.GZ31729@ZenIV.linux.org.uk> <20120722202030.GB31729@ZenIV.linux.org.uk> <500D0949.9040301@panasas.com> <20120723090304.GF31729@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Linus Torvalds , , , Stephen Rothwell , Trond Myklebust To: Al Viro Return-path: Received: from natasha.panasas.com ([67.152.220.90]:48044 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198Ab2GWQzN (ORCPT ); Mon, 23 Jul 2012 12:55:13 -0400 In-Reply-To: <20120723090304.GF31729@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 07/23/2012 12:03 PM, Al Viro wrote: > On Mon, Jul 23, 2012 at 11:20:25AM +0300, Boaz Harrosh wrote: >> On 07/22/2012 11:20 PM, Al Viro wrote: >> >>> I think the least painful solution is this: I've created a new branch >>> (for-linus-2) in there, growing off the parent of merge in nfs.git. >>> I've put the fixup to kern_path_locked() there as a separate commit >>> + stuff that went in for-linus after that point. >>> >> >> >> Does this means that between "kern_path_locked() patch" and it's fixup >> the tree is not bisectable? or is it just an enhancement/simplification? >> >> Not having any opinion, just wants to know > > It is bisectable, all right; lookup_one_len() is OK there (note that > places converted to kern_path_locked() used to use it before the > conversion. It's just that lookup_one_len() is an overkill - we > have already checked exec permissions on parent and we'd already > calculated the full qstr for last component - both length and hash. > All that is left to do is actual __lookup_hash()... Ha, right thanks. I rushed through it and was not sure of the motivation. Sounds good then. Less hassle for everybody. Thanks