From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [patch 3/7] procfs: Add ability to plug in auxiliary fdinfo providers
Date: Fri, 27 Jul 2012 07:48:28 +0400
Message-ID: <50120F8C.8010001@parallels.com>
References: <20120725094718.089879534@openvz.org> <20120725095024.842540518@openvz.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	James Bottomley <jbottomley@parallels.com>,
	Matthew Helsley <matt.helsley@gmail.com>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20120725095024.842540518@openvz.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> +static int prep_fdinfo_driver(struct proc_fdinfo_extra *extra)
> +{
> +	struct proc_fdinfo_driver *s;
> +
> +	down_read(&fdinfo_drivers_sem);
> +	list_for_each_entry(s, &fdinfo_drivers, list) {
> +		if (s->probe(extra->f_file)) {
> +			extra->driver = s;
> +			break;
> +		}
> +	}
> +	up_read(&fdinfo_drivers_sem);
> +
> +	return 0;
> +}

Maybe a simple list of file_operations:seq_operations mappings would be simpler?

> +static void *seq_next(struct seq_file *m, void *p, loff_t *pos)
> +{
> +	struct proc_fdinfo_extra *extra = m->private;
> +	void *v = NULL;
> +
> +	if (extra->driver) {
> +		int ret = 0;
> +
> +		if (*pos == 0) {
> +			v = extra->driver->ops->start(m, pos);
> +			if (v) {
> +				ret = extra->driver->ops->show(m, v);

Why is it necessary to call ->show here? The logic should be

seq_start = (pos == 0 ? nop : extra->start)
seq_next  = (pos == 0 ? extra->start : extra->next)
seq_stop  = (pos == 0 ? nop : extra->stop)
seq_show  = (pos == 0 ? proc_show : extra->show)

Or I'm missing something?

Thanks,
Pavel