From: Jeff Mahoney <jeffm@suse.de>
To: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Linux FS Maling List <linux-fsdevel@vger.kernel.org>
Subject: Re: R.I.P. pdflush
Date: Thu, 02 Aug 2012 17:27:40 -0400 [thread overview]
Message-ID: <501AF0CC.6010903@suse.de> (raw)
In-Reply-To: <1343229134-29487-1-git-send-email-artem.bityutskiy@linux.intel.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 7/25/12 11:11 AM, Artem Bityutskiy wrote:
> For example, reiserfs deadlocked quickly when I tested it using
> xfstests with resierfs quota support enabled. I spend several days
> trying to fix this, but reiserfs is quite complex and I'd say its
> locking is crazy (partially because of the BKL push-down). But I
> gave up after I realized that the dead-lock is related to the quota
> support. I disabled quotas and xfstests passed.
Thanks for mentioning this. This is due to both reiserfs_write_dquot
and reiserfs_evict_inode taking the reiserfs_write_lock. The old
reiserfs locking code depended on the recursive locking ability of the
BKL and the push-down made that a special case. This case isn't
handled so even though the write lock is supposed to be dropped to
take the journal lock safely, it's not and we end up with an ABBA case
there.
I'll work up a fix.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQGvDMAAoJEB57S2MheeWy+zMQAKUwXaF7O2WyDfl3B3/2tL6b
f+Q1BPkgD7UIgjJ9wnakb4F72+k79gLGq11V39MXfrBKnzQAgprb5Ll9eUNl1f9x
9KgAkeKQTYowYpUXfuLZUzevAX5Ys6dB3+XOWhgTaVc/L0TTgKc7aET5JotDTJM4
V6SiKcb2uqDrEk5IAo/t3pfxaSe1gOYkZWfxSOzG1l3Kp5HHJ5B6Ya4Nx5Qw2llM
Vt6fK0KLjN2kqmv80SlHRy7vOnhM1EAOrkzNuzGmdDPgAk1nBJnB8oO9W3x6WFO+
Tsc5KbiJss6Nf0dHbyNNX1hJpnyJr9kBGrVADLMZEXIqGp3eIgIy04W/QV2fvWOz
650aogYvY44mEC+55jV5RD2ubBfBhROazJsrLN4ACKIjo3KE6P/50vD8Pi9gH/F+
rq15ytztlroF3M6ejVVjfTK5BOlx+H1bIrat06aBHsyWXTcNoLpa32z6BVhldrc6
a/XdKP0CwKtIRcvr8f8zg4PHLoejaTXULJnNSQyDrIzXLz08kkEK6nxe3q1+Mp+a
uH9y6y9SToaCPcLZUT9vInnmvxL/qV/uvspPDXFsZDAMAmfFVycpwGybiuTt5Y2T
vCzOJVcCodX1cONiYfMrlNfqRGFewi0GCYTtMaz9Z1zOE9C1fwLeBorkUigxzIzT
M6uA+edSRUBjg45r1EaR
=oelZ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-08-02 21:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 15:11 R.I.P. pdflush Artem Bityutskiy
2012-07-25 15:11 ` [PATCH 01/16] vfs: kill write_super and sync_supers Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 02/16] Documentation: get rid of write_super Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 03/16] Documentation: fix the VM knobs descritpion WRT pdflush Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 04/16] ext3: nuke write_super from comments Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 05/16] ext4: " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 06/16] ext4: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 07/16] btrfs: nuke write_super " Artem Bityutskiy
2012-07-25 15:46 ` cwillu
2012-07-25 16:06 ` Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 08/16] btrfs: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 09/16] jbd/jbd2: nuke write_super " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 10/16] vfs: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 11/16] hfs: nuke write_super " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 12/16] ntfs: " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 13/16] nilfs2: " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 14/16] drbd: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 15/16] gfs2: " Artem Bityutskiy
2012-07-25 15:16 ` Bob Peterson
2012-07-26 9:10 ` Steven Whitehouse
2012-07-26 9:24 ` Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 16/16] UBIFS: " Artem Bityutskiy
2012-08-02 21:27 ` Jeff Mahoney [this message]
2012-08-03 6:53 ` R.I.P. pdflush Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501AF0CC.6010903@suse.de \
--to=jeffm@suse.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).