From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [patch 2/8] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file Date: Tue, 14 Aug 2012 18:21:48 +0400 Message-ID: <502A5EFC.7030504@parallels.com> References: <20120814140342.354405844@openvz.org> <20120814140619.952738624@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , James Bottomley , Matthew Helsley To: Cyrill Gorcunov , Al Viro , Andrew Morton Return-path: In-Reply-To: <20120814140619.952738624@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 08/14/2012 06:03 PM, Cyrill Gorcunov wrote: > This patch converts /proc/pid/fdinfo/ handling routines to seq-file which > is needed to extend seq operations and plug in auxiliary fdinfo provides > from subsystems like eventfd/eventpoll/fsnotify. > > Note the proc_fd_link no longer call for proc_fd_info, simply because > proc_fd_info is converted to seq_fdinfo_open (which is seq-file open() > prototype), moreover in further patches I need to provide two seq_fdinfo_open > variants -- one with CONFIG_CHECKPOINT_RESTORE and one without this > symbol. All in one -- this will look more messy then. > > Also, to eliminate code duplication (and Pavel's concerns) the fdinfo_open_helper > function introduced which is used in both seq_fdinfo_open and proc_fd_link. > > Signed-off-by: Cyrill Gorcunov > CC: Al Viro > CC: Alexey Dobriyan > CC: Andrew Morton > CC: Pavel Emelyanov > CC: James Bottomley Acked-by: Pavel Emelyanov