From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper Date: Thu, 16 Aug 2012 17:53:37 +0400 Message-ID: <502CFB61.5040804@parallels.com> References: <20120815092116.700948346@openvz.org> <20120815092409.591460800@openvz.org> <20120815204546.GC25062@fieldses.org> <20120815210237.GF25421@moon> <20120815220622.GA28054@fieldses.org> <20120816062448.GA32081@moon> <20120816123814.GD1209@moon> <20120816134339.GQ23464@ZenIV.linux.org.uk> <502CF9DA.8030701@parallels.com> <20120816135019.GS23464@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Cyrill Gorcunov , "J. Bruce Fields" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , Andrew Morton , James Bottomley , Matthew Helsley To: Al Viro Return-path: In-Reply-To: <20120816135019.GS23464@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 08/16/2012 05:50 PM, Al Viro wrote: > On Thu, Aug 16, 2012 at 05:47:06PM +0400, Pavel Emelyanov wrote: >> On 08/16/2012 05:43 PM, Al Viro wrote: >>> On Thu, Aug 16, 2012 at 04:38:14PM +0400, Cyrill Gorcunov wrote: >>> >>>> Hi Bruce, thinking a bit more I guess using general encode_fh is not that >>>> convenient since it operates with dentries while our fdinfo output deals >>>> with inodes. Thus I should either provide some new encode_fh variant >>>> which would deal with inodes directly without "parents". Which doesn't >>>> look for me anyhow better than the new export_encode_inode_fh helper. >>> >>> Huh? You do have dentries, for crying out loud... >> >> Sometimes we don't -- the inotify thing gets an inode only. >> Unlike other notifies that have dentries at hands... > > What's wrong with saying "we don't support idiotify"? Lot's of exiting software uses them and we cannot say something like "we cannot migrate a container with Apache running inside" :( > . Thanks, Pavel