From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper Date: Thu, 16 Aug 2012 19:06:18 +0400 Message-ID: <502D0C6A.3010908@parallels.com> References: <20120816062448.GA32081@moon> <20120816123814.GD1209@moon> <20120816134339.GQ23464@ZenIV.linux.org.uk> <502CF9DA.8030701@parallels.com> <20120816135019.GS23464@ZenIV.linux.org.uk> <20120816135448.GP32081@moon> <1345125779.3259.50.camel@dabdike.int.hansenpartnership.com> <20120816141553.GF1209@moon> <20120816144152.GT23464@ZenIV.linux.org.uk> <20120816144835.GC13066@moon> <20120816145527.GU23464@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: James Bottomley , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , Andrew Morton , Matthew Helsley To: Al Viro , Cyrill Gorcunov , "J. Bruce Fields" Return-path: In-Reply-To: <20120816145527.GU23464@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 08/16/2012 06:55 PM, Al Viro wrote: > On Thu, Aug 16, 2012 at 06:48:35PM +0400, Cyrill Gorcunov wrote: > >>> Good luck doing that with e.g. VFAT... And then there's such thing >>> as filesystems that don't have ->encode_fh() for a lot of very good >> >> Wait, Al, it seems I messed up. If some fs has no encode_fh() implemented >> the default encoding with FILEID_INO32_GEN_PARENT will be used for that. > > ... which doesn't work for a lot of filesystems. Not if you want to be > able to decode the result afterwards and get something useful out of > that. Trying to implement ->fh_to_dentry(), especially with fhandle > generated by inode alone is going to be really interesting for a bunch > of stuff... > . > Hm... Then I suppose the best we can do is -- show in a fdinfo file the inode number, device where it is and a filehandle _iff_ provided by a filesystem. For fanotify/dnotify -- only a path. Thanks, Pavel