* [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes
@ 2012-09-08 15:49 Wang Sheng-Hui
2012-09-10 16:26 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Wang Sheng-Hui @ 2012-09-08 15:49 UTC (permalink / raw)
To: Alexander Viro, linux-fsdevel, linux-kernel
The function scans @delaying_queue and stops at the first inode
whose dirtied_when is after *work->older_than_this. So the expired
ones being moved are those before *work->older_than_this. Correct
the comment here.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
fs/fs-writeback.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index be3efc4..fd255c0 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -248,7 +248,7 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
}
/*
- * Move expired (dirtied after work->older_than_this) dirty inodes from
+ * Move expired (dirtied before work->older_than_this) dirty inodes from
* @delaying_queue to @dispatch_queue.
*/
static int move_expired_inodes(struct list_head *delaying_queue,
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes
2012-09-08 15:49 [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes Wang Sheng-Hui
@ 2012-09-10 16:26 ` Jan Kara
2012-09-11 0:31 ` Fengguang Wu
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2012-09-10 16:26 UTC (permalink / raw)
To: Wang Sheng-Hui; +Cc: Alexander Viro, linux-fsdevel, linux-kernel, Wu Fengguang
On Sat 08-09-12 23:49:00, Wang Sheng-Hui wrote:
> The function scans @delaying_queue and stops at the first inode
> whose dirtied_when is after *work->older_than_this. So the expired
> ones being moved are those before *work->older_than_this. Correct
> the comment here.
Fengguang Wu would be a more appropriate for this. Added to CC. BTW the
patch is fine so feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> fs/fs-writeback.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index be3efc4..fd255c0 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -248,7 +248,7 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
> }
>
> /*
> - * Move expired (dirtied after work->older_than_this) dirty inodes from
> + * Move expired (dirtied before work->older_than_this) dirty inodes from
> * @delaying_queue to @dispatch_queue.
> */
> static int move_expired_inodes(struct list_head *delaying_queue,
> --
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes
2012-09-10 16:26 ` Jan Kara
@ 2012-09-11 0:31 ` Fengguang Wu
0 siblings, 0 replies; 3+ messages in thread
From: Fengguang Wu @ 2012-09-11 0:31 UTC (permalink / raw)
To: Jan Kara; +Cc: Wang Sheng-Hui, Alexander Viro, linux-fsdevel, linux-kernel
On Mon, Sep 10, 2012 at 06:26:33PM +0200, Jan Kara wrote:
> On Sat 08-09-12 23:49:00, Wang Sheng-Hui wrote:
> > The function scans @delaying_queue and stops at the first inode
> > whose dirtied_when is after *work->older_than_this. So the expired
> > ones being moved are those before *work->older_than_this. Correct
> > the comment here.
> Fengguang Wu would be a more appropriate for this. Added to CC. BTW the
> patch is fine so feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied. Thank you!
Fengguang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-11 0:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-08 15:49 [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes Wang Sheng-Hui
2012-09-10 16:26 ` Jan Kara
2012-09-11 0:31 ` Fengguang Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).