* [PATCH 01/22] ufs: drop vmtruncate
@ 2012-10-06 8:10 Marco Stornelli
2012-10-13 16:17 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Marco Stornelli @ 2012-10-06 8:10 UTC (permalink / raw)
To: Al Viro; +Cc: Evgeniy Dushistov, linux-kernel, Linux FS Devel
Removed vmtruncate.
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
---
fs/ufs/inode.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c
index eb6d0b7..2b43ce9 100644
--- a/fs/ufs/inode.c
+++ b/fs/ufs/inode.c
@@ -536,8 +536,9 @@ static int ufs_write_begin(struct file *file, struct address_space *mapping,
ufs_getfrag_block);
if (unlikely(ret)) {
loff_t isize = mapping->host->i_size;
- if (pos + len > isize)
- vmtruncate(mapping->host, isize);
+ if ((pos + len > isize) &&
+ inode_newsize_ok(mapping->host, isize) == 0)
+ truncate_setsize(mapping->host, isize);
}
return ret;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 01/22] ufs: drop vmtruncate
2012-10-06 8:10 [PATCH 01/22] ufs: drop vmtruncate Marco Stornelli
@ 2012-10-13 16:17 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2012-10-13 16:17 UTC (permalink / raw)
To: Marco Stornelli; +Cc: Al Viro, Evgeniy Dushistov, linux-kernel, Linux FS Devel
> @@ -536,8 +536,9 @@ static int ufs_write_begin(struct file *file, struct address_space *mapping,
> ufs_getfrag_block);
> if (unlikely(ret)) {
> loff_t isize = mapping->host->i_size;
> - if (pos + len > isize)
> - vmtruncate(mapping->host, isize);
> + if ((pos + len > isize) &&
> + inode_newsize_ok(mapping->host, isize) == 0)
> + truncate_setsize(mapping->host, isize);
write_begin always truncates down, so there should be no call to
inode_newsize_ok here.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-13 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-06 8:10 [PATCH 01/22] ufs: drop vmtruncate Marco Stornelli
2012-10-13 16:17 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).