From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: Re: [PATCH 04/21] procfs: drop vmtruncate Date: Wed, 24 Oct 2012 18:02:39 +0200 Message-ID: <5088111F.1020009@gmail.com> References: <5082965D.3070307@gmail.com> <20121024151208.GB24318@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux FS Devel , linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: In-Reply-To: <20121024151208.GB24318@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Il 24/10/2012 17:12, Christoph Hellwig ha scritto: > On Sat, Oct 20, 2012 at 02:17:33PM +0200, Marco Stornelli wrote: >> Removed vmtruncate >> >> Signed-off-by: Marco Stornelli > > As Al pointed out we probably shouldn't even allow truncate on procfs. > Can look into refusing it instead, please? > > Mmmm...for example the command "truncate --size=100 config.gz" is a nop, so it seems to me it makes no sense to support the size change, but I don't know if there are other use cases. However, should we return EPERM in case of size change checking it before inode_change_ok()? Marco