From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Hanse Subject: Re: [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages Date: Thu, 22 Nov 2012 21:27:30 +0800 Message-ID: <50AE2842.3060509@gmail.com> References: <20121116171039.3196.92186.stgit@maximpc.sw.ru> <20121121115314.20471.52148.stgit@maximpc.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: miklos@szeredi.hu, dev@parallels.com, xemul@parallels.com, fuse-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, jbottomley@parallels.com, linux-mm@kvack.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Maxim Patlasov Return-path: In-Reply-To: <20121121115314.20471.52148.stgit@maximpc.sw.ru> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 11/21/2012 08:01 PM, Maxim Patlasov wrote: > Added linux-mm@ to cc:. The patch can stand on it's own. > >> Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP >> counter is high enough. This prevents us from having too many dirty >> pages on fuse, thus giving the userspace part of it a chance to write >> stuff properly. >> >> Note, that the existing balance logic is per-bdi, i.e. if the fuse >> user task gets stuck in the function this means, that it either >> writes to the mountpoint it serves (but it can deadlock even without >> the writeback) or it is writing to some _other_ dirty bdi and in the >> latter case someone else will free the memory for it. > Signed-off-by: Maxim V. Patlasov > Signed-off-by: Pavel Emelyanov > --- > mm/page-writeback.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 830893b..499a606 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -1220,7 +1220,8 @@ static void balance_dirty_pages(struct address_space *mapping, > */ > nr_reclaimable = global_page_state(NR_FILE_DIRTY) + > global_page_state(NR_UNSTABLE_NFS); > - nr_dirty = nr_reclaimable + global_page_state(NR_WRITEBACK); > + nr_dirty = nr_reclaimable + global_page_state(NR_WRITEBACK) + > + global_page_state(NR_WRITEBACK_TEMP); > Could you explain NR_WRITEBACK_TEMP is used for accounting what? And when it will increase? > global_dirty_limits(&background_thresh, &dirty_thresh); > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org