From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] f2fs: Resolve build failures Date: Fri, 30 Nov 2012 10:21:51 -0800 Message-ID: <50B8F93F.5070909@xenotime.net> References: <1354266457-3858-1-git-send-email-jaegeuk.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org To: Jaegeuk Kim Return-path: Received: from oproxy7-pub.bluehost.com ([67.222.55.9]:59016 "HELO oproxy7-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1161023Ab2K3SWA (ORCPT ); Fri, 30 Nov 2012 13:22:00 -0500 In-Reply-To: <1354266457-3858-1-git-send-email-jaegeuk.kim@samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 11/30/2012 01:07 AM, Jaegeuk Kim wrote: > There exist two build failures reported by Randy Dunlap as follows. > > (on i386) > a. (config-r8857) > ERROR: "f2fs_xattr_advise_handler" [fs/f2fs/f2fs.ko] undefined! > > Key configs in (config-r8857) are as follows. > CONFIG_F2FS_FS=m > # CONFIG_F2FS_STAT_FS is not set > CONFIG_F2FS_FS_XATTR=y > # CONFIG_F2FS_FS_POSIX_ACL is not set > > The error was occurred due to the function location that we made a mistake. > Recently we added a new functionality for users to indicate cold files > explicitly through xattr operations (i.e., f2fs_xattr_advise_handler). > > This handler should have been added in xattr.c instead of acl.c in order > to avoid an undefined operation like in this case where XATTR is set and > ACL is not set. > > b. (config-r8855) > fs/f2fs/file.c: In function 'f2fs_vm_page_mkwrite': > fs/f2fs/file.c:97:2: error: implicit declaration of function > 'block_page_mkwrite_return' > > Key config in (config-r8855) is CONFIG_BLOCK. > > Obviously, f2fs works on top of the block device so that we should consider > carefully a sort of config dependencies. > > The reason why this error was occurred was that f2fs_vm_page_mkwrite() calls > block_page_mkwrite_return() which is enalbed only if CONFIG_BLOCK is set. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/Kconfig | 1 + > fs/f2fs/acl.c | 51 --------------------------------------------------- > fs/f2fs/xattr.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 52 insertions(+), 51 deletions(-) Thanks, that fixes the build errors that I saw. Reported-by: Randy Dunlap Acked-by: Randy Dunlap -- ~Randy