linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ys <sickamd@gmail.com>
To: david@fromorbit.com
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	adilger@dilger.ca
Subject: [PATCH] vfs: update atimes over one day in the past or future
Date: Sat, 15 Dec 2012 23:25:23 +0800	[thread overview]
Message-ID: <50CC9663.4010200@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-vfs-update-atimes-over-one-day-in-the-past-or-future.patch --]
[-- Type: text/x-patch; name="0001-vfs-update-atimes-over-one-day-in-the-past-or-future.patch", Size: 1587 bytes --]

>From 3d56c131b58a21c05bcd677b9d2ba915abcbf195 Mon Sep 17 00:00:00 2001
From: yangsheng <sickamd@gmail.com>
Date: Sat, 15 Dec 2012 21:46:22 +0800
Subject: [PATCH] vfs: update atimes over one day in the past or future

Relatime should update the inode atime if it is more than one day
in the future.  The original problem seen was a tarball that had
a bad atime in the distant future, but could also happen if someone
fat-fingers a "touch".  The future atime will never be fixed.

Without relatime enabled, a future atime is updated to the current
kernel time on access.  Relatime is meant to reduce the frequency
of atime updates, not decide if whether the system clock or the
inode timestamp is correct or not.

Signed-off-by: Yang Sheng <sickamd@gmail.com>
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Acked-by: David Chinner <david@fromorbit.com>
CC: stable@vger.kernel.org
---
 fs/inode.c | 7 ++++---
 1 个文件被修改,插入 4 行(+),删除 3 行(-)

diff --git a/fs/inode.c b/fs/inode.c
index 14084b7..8713dc8 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1488,10 +1488,11 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode,
 		return 1;
 
 	/*
-	 * Is the previous atime value older than a day? If yes,
-	 * update atime:
+	 * Update atime if it's older than a day or more than a day
+	 * in the future, which we assume is corrupt.
+	 * 	 	 
 	 */
-	if ((long)(now.tv_sec - inode->i_atime.tv_sec) >= 24*60*60)
+	if (abs(now.tv_sec - inode->i_atime.tv_sec) >= 24*60*60)
 		return 1;
 	/*
 	 * Good, we can skip the atime update:
-- 
1.7.11.7


             reply	other threads:[~2012-12-15 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-15 15:25 ys [this message]
2012-12-16  2:15 ` [PATCH] vfs: update atimes over one day in the past or future Dave Chinner
2012-12-18 12:14   ` Andreas Dilger
2012-12-18 21:14     ` Dave Chinner
2012-12-26  4:33       ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CC9663.4010200@gmail.com \
    --to=sickamd@gmail.com \
    --cc=adilger@dilger.ca \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).