From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alarsen.net (mail.alarsen.net [144.76.18.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 353263B9DAC for ; Mon, 11 May 2026 08:20:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.76.18.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487619; cv=none; b=Kck/5qQZUgiHiZ7UtQ9LLJS9U6ERwouximGWM4gTVu36JJ9Fb32L3mq1K99KBiYXMxL0XTAsRy0rgxFawnnkT3TSmlW1C/OiuUZbqdTCCucxYtmn3dqffV35jv/GPh7l/QZQo6fHioe/A2YPdqEq5EYAARQMKqiMjx7P5Ct9NQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487619; c=relaxed/simple; bh=tupWpp1Wr/DI+50gRTgVZY8E+35pNiscrazte+ahbsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KATXVH+Yot6/Pt6xdTmoOZSkMD3NDFaQqv7cVQ8vfTO0HX/UD6gabj8KWzmHbX0DFVNNs+6biTWzrBvNXar+MfJklhYFXukrjIy1ciTPeYFoIMEkHL05UShsf5XxqIXgg5PK+pxvInrQ4zJQNrXapkfKzUmLyhAeUIqDyMEeHDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=alarsen.net; spf=pass smtp.mailfrom=alarsen.net; dkim=pass (2048-bit key) header.d=alarsen.net header.i=@alarsen.net header.b=ZZSN9Lrs; arc=none smtp.client-ip=144.76.18.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=alarsen.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alarsen.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alarsen.net header.i=@alarsen.net header.b="ZZSN9Lrs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alarsen.net; s=joe; t=1778487605; bh=Q5o7BZ/IFYZCK+kK5yddBBzChwDObHCsyIubnxvYSmc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZZSN9LrsVT7dohE8ai7eKJGMr5SuA7zH+HHwitlxs3JKuYJs7z2bHWxaN+bqvP81J Dvq85yefYMYDdk+KvAenBO6Wy+EvHUCMM4mCn6gTYGotMWh704lwc01jKn/YO1O1Ob NCkBoGPLcpSok9gU60MkR2V14aafG3leCjZIUKWe4xX7pzcsoxTGtJxEf24pe01bEw 1BzdyhwafvSPpu918XXxZuUXj9t6tXzb6UwmGMRz+L1C6QLSnt2OUXfFCGbVomQWCW 20YdrofoJObVueZ3kYKRDXaeMjGJJZ59XA18udJNZ6kWoy6fOEUQ5ANwEt9js3q7tT Rk8hOuCEDMe3A== Received: from oscar.alarsen.net (unknown [IPv6:fd8b:531:bccf:96:13c6:f483:161f:2523]) by joe.alarsen.net (Postfix) with ESMTPS id CD261180276; Mon, 11 May 2026 10:20:05 +0200 (CEST) Received: from oscar.localnet (localhost [IPv6:::1]) by oscar.alarsen.net (Postfix) with ESMTP id BC291719; Mon, 11 May 2026 10:20:05 +0200 (CEST) From: Anders Larsen To: Christoph Hellwig , Jan Kara Cc: Alexander Viro , Christian Brauner , David Sterba , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Mikulas Patocka , Dave Kleikamp , Konstantin Komarov , Bob Copeland , linux-fsdevel@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, linux-karma-devel@lists.sourceforge.net Subject: Re: [PATCH 03/10] qnx4: handle set_blocksize failures Date: Mon, 11 May 2026 10:20:05 +0200 Message-ID: <5102053.31r3eYUQgx@oscar> In-Reply-To: <20260511074556.GA28186@lst.de> References: <20260511071701.2456211-1-hch@lst.de> <12893675.O9o76ZdvQC@oscar> <20260511074556.GA28186@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On 2026-05-11 09:45 Christoph Hellwig wrote: > On Mon, May 11, 2026 at 09:42:49AM +0200, Anders Larsen wrote: > > On 2026-05-11 09:16 Christoph Hellwig wrote: > > > qnx4 uses buffer_heads, which don't handle block size > PAGE_SIZE well. > > > > qnx4fs uses a fixed block size of 512 bytes, so this will never happen. > > > > > - sb_set_blocksize(s, QNX4_BLOCK_SIZE); > > > + if (!sb_set_blocksize(s, QNX4_BLOCK_SIZE)) > > > + return -EINVAL; > > > > QNX4_BLOCK_SIZE is a constant (512)... > > Yes, which means that sb_set_blocksize fails when the device has an LBA > size larger than 512 bytes, and this failure should be handled. OK, so I misunderstood the issue. In that case: Acked-by: Anders Larsen