From: Rich Johnston <rjohnston@sgi.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: <xfs@oss.sgi.com>, <linux-fsdevel@vger.kernel.org>,
<linux-ext4@vger.kernel.org>, <dchinner@redhat.com>
Subject: Re: [PATCH 03/10] xfstests: hardcode fops for determinable fsstests runs
Date: Fri, 1 Mar 2013 09:43:27 -0600 [thread overview]
Message-ID: <5130CC9F.4090207@sgi.com> (raw)
In-Reply-To: <1361356935-29153-4-git-send-email-dmonakhov@openvz.org>
On 02/20/2013 04:42 AM, Dmitry Monakhov wrote:
> 106,107 and 117 are frozen tests which use known seed, it is
> reasonable to explicitly hardcode file operations in order to avoid
> implicit changes caused by future changes in fsstress.
>
> NOTE: options genereted like follows: fsstress -S c $ORIG_ARGS
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
106 and 107 are not valid for ext4. They failed the same before and
after this patch with xfs. Because 106 and 107 are not in the auto group
and 117 is in the auto group and passes for both xfs and ext4,
I will say this looks good.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
> ---
> 106 | 33 +++++++++++++++++++++++++++++++--
> 107 | 32 +++++++++++++++++++++++++++++---
> 2 files changed, 60 insertions(+), 5 deletions(-)
>
> diff --git a/106 b/106
> index 8278691..b351fe5 100755
> --- a/106
> +++ b/106
> @@ -61,8 +61,37 @@ _require_prjquota $SCRATCH_DEV
>
> # initial populate
> target=$SCRATCH_MNT/target
> -$FSSTRESS_PROG -s 0xdeed -m8 -w -p4 -n1000 $FSSTRESS_AVOID -d $target
> -$FSSTRESS_PROG -s 0xdeed -m8 -z -p4 -n1000 -fsetxattr=500 -fchown=500 -d $target
> +$FSSTRESS_PROG -z -s 57069 -m 8 -n 1000 -p 4 \
> +-f allocsp=1 \
> +-f chown=3 \
> +-f creat=4 \
> +-f dwrite=4 \
> +-f fallocate=1 \
> +-f fdatasync=1 \
> +-f fiemap=1 \
> +-f freesp=1 \
> +-f fsync=1 \
> +-f link=1 \
> +-f mkdir=2 \
> +-f mknod=2 \
> +-f punch=1 \
> +-f rename=2 \
> +-f resvsp=1 \
> +-f rmdir=1 \
> +-f setxattr=1 \
> +-f symlink=2 \
> +-f sync=1 \
> +-f truncate=2 \
> +-f unlink=1 \
> +-f unresvsp=1 \
> +-f write=4 \
> +-d $target
> +
> +$FSSTRESS_PROG -z -s 57069 -m 8 -n 1000 -p 4 \
> +-f chown=500 \
> +-f setxattr=500 \
> +-d $target
> +
>
> # also use space, to be able to go over/under limits easily
> uid=255
> diff --git a/107 b/107
> index 74403e6..eaf7e6a 100755
> --- a/107
> +++ b/107
> @@ -78,9 +78,35 @@ echo "6:$target" | tee -a $seq.full > $tmp.projects
>
> echo "### populate filesystem"
> mkdir $target || exit
> -FSSTRESS_AVOID="$FSSTRESS_AVOID -fmknod=0 -fsymlink=0"
> -$FSSTRESS_PROG -s 0xfeed -m8 -w -p4 -n1000 $FSSTRESS_AVOID -d $target
> -$FSSTRESS_PROG -s 0xbabe -m8 -z -p4 -n500 -fsetxattr=250 -fchown=250 -d $target
> +$FSSTRESS_PROG -z -s 65261 -m 8 -n 1000 -p 4 \
> +-f allocsp=1 \
> +-f chown=3 \
> +-f creat=4 \
> +-f dwrite=4 \
> +-f fallocate=1 \
> +-f fdatasync=1 \
> +-f fiemap=1 \
> +-f freesp=1 \
> +-f fsync=1 \
> +-f link=1 \
> +-f mkdir=2 \
> +-f punch=1 \
> +-f rename=2 \
> +-f resvsp=1 \
> +-f rmdir=1 \
> +-f setxattr=1 \
> +-f sync=1 \
> +-f truncate=2 \
> +-f unlink=1 \
> +-f unresvsp=1 \
> +-f write=4 \
> +-d $target
> +
> +$FSSTRESS_PROG -z -s 47806 -m 8 -n 500 -p 4 \
> +-f chown=250 \
> +-f setxattr=250 \
> +-d $target
> +
>
> QARGS="-x -D $tmp.projects -P /dev/null $SCRATCH_MNT"
>
>
next prev parent reply other threads:[~2013-03-01 15:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 10:42 [PATCH 00/10] xfstests: Stress tests improments v5 Dmitry Monakhov
2013-02-20 10:42 ` [PATCH 01/10] xfstests: add fio requirement V2 Dmitry Monakhov
2013-03-01 15:43 ` Rich Johnston
2013-02-20 10:42 ` [PATCH 02/10] xfstest: add configurable load factors Dmitry Monakhov
2013-03-01 15:43 ` Rich Johnston
2013-02-20 10:42 ` [PATCH 03/10] xfstests: hardcode fops for determinable fsstests runs Dmitry Monakhov
2013-03-01 15:43 ` Rich Johnston [this message]
2013-02-20 10:42 ` [PATCH 04/10] xfstets: fsstress add replace file operation Dmitry Monakhov
2013-03-01 15:43 ` Rich Johnston
2013-02-20 10:42 ` [PATCH 05/10] xfstest: allow fsstress to use load factor where appropriate Dmitry Monakhov
2013-03-01 15:43 ` Rich Johnston
2013-02-20 10:42 ` [PATCH 06/10] xfstest: move run_check to common.rc Dmitry Monakhov
2013-03-01 15:44 ` Rich Johnston
2013-02-20 10:42 ` [PATCH 07/10] xfstest: add fallocate/truncate vs AIO/DIO stress test Dmitry Monakhov
2013-03-01 17:49 ` Rich Johnston
2013-02-20 10:42 ` [PATCH 08/10] xfstest: add fallocate/punch_hole " Dmitry Monakhov
2013-03-01 17:50 ` Rich Johnston
2013-02-20 10:42 ` [PATCH 09/10] xfstest: add defragmentation stress tests for ext4 Dmitry Monakhov
2013-03-01 19:23 ` Rich Johnston
2013-03-02 1:30 ` Dmitry Monakhov
2013-03-04 23:19 ` Rich Johnston
2013-03-03 16:43 ` Zheng Liu
2013-03-03 17:23 ` Zheng Liu
2013-02-20 10:42 ` [PATCH 10/10] xfstests: add disk failure simulation test Dmitry Monakhov
2013-03-01 20:11 ` Rich Johnston
2013-03-02 1:49 ` Dmitry Monakhov
2013-03-04 23:44 ` Rich Johnston
2013-02-25 15:45 ` [PATCH 00/10] xfstests: Stress tests improments v5 Theodore Ts'o
2013-02-25 21:28 ` Ben Myers
2013-02-25 22:09 ` Dave Chinner
2013-02-25 23:00 ` Ben Myers
2013-03-01 20:23 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130CC9F.4090207@sgi.com \
--to=rjohnston@sgi.com \
--cc=dchinner@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).