From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org,
sage@inktank.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 2/2] fs: fix dentry_lru_prune()
Date: Fri, 08 Mar 2013 10:43:00 +0800 [thread overview]
Message-ID: <51395034.40709@intel.com> (raw)
In-Reply-To: <20130308020445.GB23616@dastard>
On 03/08/2013 10:04 AM, Dave Chinner wrote:
> On Thu, Mar 07, 2013 at 07:37:36PM +0800, Yan, Zheng wrote:
>> From: "Yan, Zheng" <zheng.z.yan@intel.com>
>>
>> dentry_lru_prune() should always call file system's d_prune callback.
>
> Why? What bug does this fix?
>
Ceph uses a flag to track if the dcache contents for a directory are complete,
and it relies on d_prune() to clear the flag when some dentries are trimmed.
We noticed that dentry_lru_prune() sometimes does not call ceph_d_prune().
It seems the dentry in question is ancestor trimmed by try_prune_one_dentry().
Regards
Yan, Zheng
next prev parent reply other threads:[~2013-03-08 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 11:37 [PATCH 2/2] fs: fix dentry_lru_prune() Yan, Zheng
2013-03-08 2:04 ` Dave Chinner
2013-03-08 2:43 ` Yan, Zheng [this message]
2013-03-08 6:27 ` Dave Chinner
2013-03-08 6:40 ` Yan, Zheng
2013-03-09 9:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51395034.40709@intel.com \
--to=zheng.z.yan@intel.com \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sage@inktank.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).