From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Fietkau Subject: Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17) Date: Wed, 13 Mar 2013 19:37:50 +0100 Message-ID: <5140C77E.7030206@openwrt.org> References: <1363184193-1796-1-git-send-email-miklos@szeredi.hu> <20130313181251.GA6023@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Sedat Dilek , Miklos Szeredi , viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org, apw@canonical.com, neilb@suse.de, jordipujolp@gmail.com, ezk@fsl.cs.sunysb.edu, dhowells@redhat.com, sedat.dilek@googlemail.com, hooanon05@yahoo.co.jp, mszeredi@suse.cz To: Robin Holt Return-path: In-Reply-To: <20130313181251.GA6023@sgi.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 2013-03-13 7:12 PM, Robin Holt wrote: > On Wed, Mar 13, 2013 at 05:51:33PM +0100, Sedat Dilek wrote: >> On Wed, Mar 13, 2013 at 5:21 PM, Miklos Szeredi wrote: >> > On Wed, Mar 13, 2013 at 5:10 PM, Sedat Dilek wrote: >> > >> >> Anyway, with CONFIG_OVERLAYFS_FS=m I do not see any related messages >> >> when the kernel-module is loaded. >> >> So, is this intended? >> >> SquashFS prints into the logs, so what is it doing differently? >> > >> > Some modules do, some don't. It's not compulsory and not very useful. >> > >> >> What about... >> >> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c >> index 482c26f..92b9ad5 100644 >> --- a/fs/overlayfs/super.c >> +++ b/fs/overlayfs/super.c >> @@ -675,11 +675,13 @@ MODULE_ALIAS_FS("overlayfs"); >> static int __init ovl_init(void) >> { >> return register_filesystem(&ovl_fs_type); >> + printk(KERN_INFO "overlayfs: loaded\n"); > > How about pr_debug(). That makes things quite for most of us but gives > you info when looking for things like boot problems. How is having a printk/pr_debug useful here at all? The fact that other filesystems do this as well is not a good reason... Also, putting it *after* the return statement doesn't make much sense ;) - Felix