From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Subject: Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page() Date: Fri, 22 Mar 2013 11:18:05 -0700 Message-ID: <514CA05D.6030302@sr71.net> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-17-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Kirill A. Shutemov" Return-path: In-Reply-To: <1363283435-7666-17-git-send-email-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > +static int split_anon_huge_page(struct page *page) > { > struct anon_vma *anon_vma; > int ret = 1; > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > - BUG_ON(!PageAnon(page)); Did you really mean to kill these BUG_ON()s? They still look relevant to me. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org