From: Chao Yu <chao@kernel.org>
To: Nanzhe Zhao <nzzhao@126.com>
Cc: chao@kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add 'folio_in_bio' to handle readahead folios with no BIO submission
Date: Mon, 12 Jan 2026 17:24:07 +0800 [thread overview]
Message-ID: <5158ff31-bd7b-4071-b2b1-12cb75c858dd@kernel.org> (raw)
In-Reply-To: <13c7c3ce.71fa.19bb1687da1.Coremail.nzzhao@126.com>
On 1/12/2026 4:52 PM, Nanzhe Zhao wrote:
>
> At 2026-01-12 09:02:48, "Chao Yu" <chao@kernel.org> wrote:
>>> @@ -2545,6 +2548,11 @@ static int f2fs_read_data_large_folio(struct inode *inode,
>>> }
>>> trace_f2fs_read_folio(folio, DATA);
>>> if (rac) {
>>> + if (!folio_in_bio) {
>>> + if (!ret)
>>
>> ret should never be true here?
>>
>> Thanks,
> Yes.Need I send a v3 patch to remove the redundant check?
Yes, I think so.
Thanks,
>
> Thanks,
> Nanzhe Zhao
next prev parent reply other threads:[~2026-01-12 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 10:09 [f2fs-dev] [PATCH v2 0/2] f2fs: fix large folio read corner cases for immutable files Nanzhe Zhao
2026-01-11 10:09 ` [f2fs-dev] [PATCH v2 1/2] f2fs: add 'folio_in_bio' to handle readahead folios with no BIO submission Nanzhe Zhao
2026-01-12 1:02 ` Chao Yu
2026-01-12 8:52 ` Nanzhe Zhao
2026-01-12 9:24 ` Chao Yu [this message]
2026-01-13 17:05 ` Jaegeuk Kim
2026-01-16 3:31 ` Nanzhe Zhao
2026-01-16 8:53 ` Chao Yu
2026-01-13 18:32 ` Matthew Wilcox
2026-01-16 4:33 ` Jaegeuk Kim
2026-01-11 10:09 ` [f2fs-dev] [PATCH v2 2/2] f2fs: advance index and offset after zeroing in large folio read Nanzhe Zhao
2026-01-12 1:03 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5158ff31-bd7b-4071-b2b1-12cb75c858dd@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nzzhao@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox