linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Zhao Hongjiang <zhaohongjiang37@gmail.com>
Cc: <david@fromorbit.com>, <linux-fsdevel@vger.kernel.org>,
	<linux-ext4@vger.kernel.org>, <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: Check concurrently of readdir and read on the same directory fd
Date: Fri, 5 Apr 2013 12:28:29 -0500	[thread overview]
Message-ID: <515F09BD.606@sgi.com> (raw)
In-Reply-To: <515BC786.3070102@gmail.com>

Zhao,

Thanks for submitting this test.

Only two minor errors that will be corrected at commit time.

1. The new script used generate this test produces errors.
   No need to resubmit, this has already been fixed by
   commit 8575764a "xfstests: fix common source file path"

      QA output created by 310
     +./tests/generic/310: line 43: ./common.rc: No such file or directory
     +./tests/generic/310: line 44: ./common.filter: No such file or 
directory
     +./tests/generic/310: line 47: _supported_fs: command not found
     +./tests/generic/310: line 48: _supported_os: command not found

2. Whitespace errors
   Warning: trailing whitespace in line 18 of src/t_readdir_2.c
   Warning: trailing whitespace in lines 18,28 of src/t_readdir_1.c

   space before tab in indent. tests/generic/310
                                 	perror("Seek failed!");
warning: 1 line adds whitespace errors.

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

  reply	other threads:[~2013-04-05 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  6:09 [PATCH] xfstests: Check concurrently of readdir and read on the same directory fd Zhao Hongjiang
2013-04-05 17:28 ` Rich Johnston [this message]
2013-04-05 17:32 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515F09BD.606@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=david@fromorbit.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    --cc=zhaohongjiang37@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).