From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: [PATCH 0/2 v2][RFC] fsfreeze: from uninterruptible to killable Date: Mon, 08 Apr 2013 18:20:51 +0200 Message-ID: <5162EE63.2010301@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jan Kara , Al Viro To: Linux FS Devel Return-path: Received: from mail-ee0-f44.google.com ([74.125.83.44]:33034 "EHLO mail-ee0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759492Ab3DHQ17 (ORCPT ); Mon, 8 Apr 2013 12:27:59 -0400 Received: by mail-ee0-f44.google.com with SMTP id c41so1474595eek.17 for ; Mon, 08 Apr 2013 09:27:58 -0700 (PDT) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, after some comments, I changed the scope of the patch series. As Al said the call of freezing are too deep in the call chain and to avoid several headaches it's better to manage an interruption by sigkill only when the call are enough "near" to the user space. About the pagefault: actually the return VM_FAULT_RETRY from page_mkwrite it seems possible but it can create some problem to the callers. Inside page_mkwrite we should check if the caller has set FAULT_FLAG_ALLOW_RETRY but this flag is not passed to the page_mkwrite callback, any tips about this point? Marco Stornelli (2): fsfreeze: add new internal __sb_start_write_wait fsfreeze: replace sb_start_write with sb_start_write_killable fs/btrfs/file.c | 4 +++- fs/cifs/file.c | 4 +++- fs/fuse/file.c | 4 +++- fs/ntfs/file.c | 4 +++- fs/ocfs2/file.c | 4 +++- fs/open.c | 8 ++++++-- fs/splice.c | 4 +++- fs/super.c | 47 ++++++++++++++++++++++++++++++++++++++++------- fs/xfs/xfs_file.c | 4 +++- include/linux/fs.h | 23 ++++++++++++++++++----- mm/filemap.c | 4 +++- mm/filemap_xip.c | 4 +++- 12 files changed, 91 insertions(+), 23 deletions(-) -- 1.7.3.4 ---