linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Stornelli <marco.stornelli@gmail.com>
To: linux-mm@kvack.org
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Return value of __mm_populate
Date: Sat, 13 Apr 2013 14:14:34 +0200	[thread overview]
Message-ID: <51694C2A.4050906@gmail.com> (raw)

Hi,

I was seeing the code of __mm_populate (in -next) and I've got a doubt 
about the return value. The function __mlock_posix_error_return should 
return a proper error for mlock, converting the return value from 
__get_user_pages. It checks for EFAULT and ENOMEM. Actually 
__get_user_pages could return, in addition, ERESTARTSYS and EHWPOISON. 
So it seems to me that we could return to user space not expected value. 
I can't see them on the man page. In addition we shouldn't ever return 
ERESTARTSYS to the user space but EINTR. According to the man pages 
maybe we should return EAGAIN in these cases. Am I missing something?

Thanks,

Marco

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2013-04-13 12:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 12:14 Marco Stornelli [this message]
2013-04-14  0:18 ` Return value of __mm_populate KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51694C2A.4050906@gmail.com \
    --to=marco.stornelli@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).